Skip to content

fix: remove Thread.sleep() from DefaultWorkQueueTest - #4910

Open
sarveshkaushal wants to merge 1 commit into
kubernetes-client:masterfrom
sarveshkaushal:sarveshkaushal/flaky-tests
Open

sarveshkaushal wants to merge 1 commit into
kubernetes-client:masterfrom
sarveshkaushal:sarveshkaushal/flaky-tests

Conversation

@sarveshkaushal

Copy link
Copy Markdown
Contributor

Notes

This change removes the Thread.sleep() dependency on the DefaultWorkQueueTest and replaces it with explicit thread synchronization.. This is related to issue #1223

Testing

Ran mvn install from project root and build completed successfully.

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sarveshkaushal
Once this PR has been reviewed and has the lgtm label, please assign brendandburns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 17, 2026
@sarveshkaushal

Copy link
Copy Markdown
Contributor Author

/assign @brendandburns
/assign @yue9944882

@brendandburns

Copy link
Copy Markdown
Contributor

I think there are a lot of whitespace changes that make this hard to review because it makes the diff much bigger than it needs to be.

Please minimize the diff and then I can do a real review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants