fix: remove Thread.sleep() from DefaultWorkQueueTest - #4910
Open
sarveshkaushal wants to merge 1 commit into
Open
sarveshkaushal wants to merge 1 commit into
sarveshkaushal wants to merge 1 commit into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sarveshkaushal The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/assign @brendandburns |
Contributor
|
I think there are a lot of whitespace changes that make this hard to review because it makes the diff much bigger than it needs to be. Please minimize the diff and then I can do a real review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
This change removes the Thread.sleep() dependency on the
DefaultWorkQueueTestand replaces it with explicit thread synchronization.. This is related to issue #1223Testing
Ran
mvn installfrom project root and build completed successfully.