Skip to content

fix(workflow): correct loop boolean break condition values - #41186

Open
HelloSrauker wants to merge 1 commit into
langgenius:mainfrom
HelloSrauker:codex/fix-loop-boolean-break-condition
Open

fix(workflow): correct loop boolean break condition values#41186
HelloSrauker wants to merge 1 commit into
langgenius:mainfrom
HelloSrauker:codex/fix-loop-boolean-break-condition

Conversation

@HelloSrauker

@HelloSrauker HelloSrauker commented Aug 24, 2026

Copy link
Copy Markdown

Summary

  • store new Loop Boolean break-condition defaults as actual booleans
  • keep Boolean values typed when switching an existing condition to a Boolean variable
  • normalize legacy "true" / "false" values before rendering the Boolean selector
  • add regression tests for legacy rendering and Boolean variable selection

Fixes #41185

Screenshots

N/A. The behavior is covered by focused regression tests.

Checklist

  • This change requires a documentation update, included: N/A; no documentation change is required.
  • I understand that this PR may be closed in case there was no previous discussion or issues.
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly. N/A; no documentation change is required.
  • I ran make lint && make type-check (backend) and vp staged (frontend) to appease the lint gods.

Verification

  • Loop unit suite: 9 files, 33 tests passed
  • Web TypeScript check: passed
  • Formatting check: all 4 changed files are correctly formatted
  • Focused vp check: reports 2 pre-existing a11y errors and 3 pre-existing icon warnings on untouched lines in condition-item.tsx; no out-of-scope auto-fix was applied

From Codex

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 24, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loop boolean break condition renders string "false" as True

1 participant