Skip to content

chore: document Ruby 3.4 requirement in README - #14

Draft
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1786352814-readme-ruby-version
Draft

devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1786352814-readme-ruby-version

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

Docs-only. The README's build instructions never state a Ruby requirement, but the example genuinely cannot install on older Rubies: both launchdarkly-openfeature-server-sdk (0.2.0) and openfeature-sdk (0.6.5) declare required_ruby_version >= 3.4. On Ruby 3.0 bundle install fails with:

Because launchdarkly-openfeature-server-sdk >= 0.2.0 depends on Ruby >= 3.4
  and Gemfile depends on launchdarkly-openfeature-server-sdk ~> 0.2,
  Ruby >= 3.4 is required.

This matches the ruby-version: 3.4 already used in CI. No dependency changes: every Gemfile constraint already resolves to the latest published version (launchdarkly-server-sdk 8.14.0, launchdarkly-openfeature-server-sdk 0.2.0 under ~> 0.2, openfeature-sdk 0.6.5, listen 3.10.0 under ~> 3.3) and no Gemfile.lock is committed, so there is nothing to bump.

Testing

Built and ran the example locally on Ruby 3.4.7 against a real LaunchDarkly environment:

$ LAUNCHDARKLY_SDK_KEY=*** bundle exec ruby main.rb
*** The sample-feature feature flag evaluates to false.

Also ran with RUBYOPT=-w: no deprecation warnings originate from main.rb; the noise is internal to third-party gems (http-cookie, openfeature-sdk circular require, LD SDK unused-variable warnings). No deprecated LD SDK or OpenFeature APIs are used — set_provider_and_wait and fetch_boolean_value are both current in openfeature-sdk 0.6.5.

Link to Devin session: https://app.devin.ai/sessions/577d0b569d8f4f01b835426cb5c7a202
Requested by: @jsonbailey

The launchdarkly-openfeature-server-sdk and openfeature-sdk gems require Ruby >= 3.4, matching the CI ruby-version.

Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

@cursor review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devin-pr PR created by Devin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants