chore: document Ruby 3.4 requirement in README - #14
Draft
devin-ai-integration[bot] wants to merge 1 commit into
Draft
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
The launchdarkly-openfeature-server-sdk and openfeature-sdk gems require Ruby >= 3.4, matching the CI ruby-version. Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs-only. The README's build instructions never state a Ruby requirement, but the example genuinely cannot install on older Rubies: both
launchdarkly-openfeature-server-sdk(0.2.0) andopenfeature-sdk(0.6.5) declarerequired_ruby_version >= 3.4. On Ruby 3.0bundle installfails with:This matches the
ruby-version: 3.4already used in CI. No dependency changes: every Gemfile constraint already resolves to the latest published version (launchdarkly-server-sdk8.14.0,launchdarkly-openfeature-server-sdk0.2.0 under~> 0.2,openfeature-sdk0.6.5,listen3.10.0 under~> 3.3) and noGemfile.lockis committed, so there is nothing to bump.Testing
Built and ran the example locally on Ruby 3.4.7 against a real LaunchDarkly environment:
Also ran with
RUBYOPT=-w: no deprecation warnings originate frommain.rb; the noise is internal to third-party gems (http-cookie,openfeature-sdkcircular require, LD SDK unused-variable warnings). No deprecated LD SDK or OpenFeature APIs are used —set_provider_and_waitandfetch_boolean_valueare both current inopenfeature-sdk0.6.5.Link to Devin session: https://app.devin.ai/sessions/577d0b569d8f4f01b835426cb5c7a202
Requested by: @jsonbailey