chore: Add the EventSource implementation to @launchdarkly/eventsource-node - #2003
Draft
joker23 wants to merge 1 commit into
Conversation
joker23
added this pull request to stack #2004
September 10, 2026 17:46
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
joker23
force-pushed
the
skz/sdk-2924/migrate-node-eventsource-implementation
branch
from
September 10, 2026 19:23
00337b9 to
5164fe5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second layer of the eventsource migration stack. Adds the
EventSourceimplementation to@launchdarkly/eventsource-node: a close-to-verbatim port of thelaunchdarkly-eventsourcenpm package's SSE client onto Nodehttp/https, together with all of its unit tests (the package suite is 114 tests). Two deliberate deviations from the original: TLS certificate verification follows Node's own default (the legacy top-levelrejectUnauthorizedalias and its verification-disabled default are removed), and the Node-inertwithCredentialsoption is dropped. Finalizessrc/index.tsto export the implementation.