-
Notifications
You must be signed in to change notification settings - Fork 0
feat(client): Agent Skills — retrieval through an injectable store (2/5) #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
27ef12f
feat(client): Agent Skills — retrieval through an injectable store
XieX 1afb690
feat(client): a documented log record for skill integrity failures
XieX 8ad49f2
feat(client): descriptor-pinned filesystem primitives
XieX f1aad0a
test(client): Agent Skills — the filesystem abuse matrix
XieX 568729d
feat(client): Agent Skills — materialize onto disk under a manifest
XieX c88d5bf
test(client): assert rename containment through the branching helper
XieX 49c2741
feat(client): Agent Skills — self-healing reconciles, and keys no fil…
XieX eda4ae1
feat(client): Agent Skills — a distinguishable outcome for integrity …
XieX 6a0e6aa
docs(client): Agent Skills — close out the security review's SDK-side…
XieX dd2d55c
feat(client): Agent Skills — re-reconcile on delivery with watch_skills
XieX 0f797c0
feat(client): Agent Skills — the FDv2 delivery protocol, without the …
XieX e2b54fd
feat(client): an unheld version pin is a miss, not an integrity failure
XieX 5817d89
fix(client): a broken store answer is not an absent skill
XieX 29ad3fe
fix(client): attach the skill watcher's listener before its first rec…
XieX 9571dca
chore: merge split/skills-retrieval into split/skills-safe-fs
XieX a6aae0a
chore: merge split/skills-safe-fs into split/skills-materialization
XieX 4c6d965
test(client): a broken store answer never deletes managed files
XieX 1cf5235
feat(client): Agent Skills — name the payload a transfer completed
XieX efc4ca7
fix(client): Agent Skills — read the skill's version off the wire key
XieX b6a25f9
feat(client): Agent Skills — the FDv2 delivery transport
XieX c285ff5
fix(client): retry an FDv2 stream that dies mid-read
XieX daf04a6
fix(client): raise the skill content cap to 10 MiB
XieX b7ee71a
fix(client): keep FDv2 delivery alive on an idle stream, and shut dow…
XieX 88c225e
fix(client): log a recycled FDv2 stream at debug rather than warning
XieX d2386c8
feat(client): Agent Skills — the FDv2 delivery transport (#83)
XieX 96576aa
feat(client): Agent Skills — the FDv2 delivery protocol, without the …
XieX 09d7b60
feat(client): Agent Skills — re-reconcile on delivery with watch_skil…
XieX 51f06a6
docs(client): Agent Skills — close out the security review's SDK-side…
XieX 7b59680
feat(client): Agent Skills — a distinguishable outcome for integrity …
XieX b62571e
feat(client): Agent Skills — self-healing reconciles, and keys no fil…
XieX ba215ef
test(client): Agent Skills — the filesystem abuse matrix (5/5) (#54)
XieX 71a2531
feat(client): Agent Skills — materialize onto disk under a manifest (…
XieX dad1d30
feat(client): descriptor-pinned filesystem primitives (3/5) (#52)
XieX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this new
_resolve_clientmethod? Or can we continue to use theinit_clientmethod as it was before and set the store at the appropriate point in the initialization?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skill store is different than the other things we set in that,
That's why
_resolve_clientwas introduced, just to wrap all of thereturnpaths and set the skill store once, instead of 3 or 4 times throughout.