Skip to content

Prepare ldproxy v5: migrate deprecated configuration options - #500

Open
cportele wants to merge 1 commit into
masterfrom
v5-deprecated-options-migration
Open

cportele wants to merge 1 commit into
masterfrom
v5-deprecated-options-migration

Conversation

@cportele

Copy link
Copy Markdown
Contributor

Migrate the deprecated backgroundTasks.maxThreads to jobs.maxConcurrent

The deprecated value is applied when the configuration is loaded (@Value.Check on AppConfiguration) if jobs.maxConcurrent has its default value. Consumers only read jobs.maxConcurrent.

Note that the base configuration used the wrong key for the default jobs concurrency (maxConcurrentJobs instead of maxConcurrent), which made the environment variable JOBS_MAX_CONCURRENT_JOBS ineffective.

…ncurrent

The deprecated value is applied when the configuration is loaded (@Value.Check
on AppConfiguration) if jobs.maxConcurrent has its default value. Consumers
only read jobs.maxConcurrent.

The base configuration used the wrong key for the default jobs concurrency
(maxConcurrentJobs instead of maxConcurrent), which made the environment
variable JOBS_MAX_CONCURRENT_JOBS ineffective.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant