Repository navigation
chore: address weekly linting report - #1168
Open
jessealama wants to merge 4 commits into
Open
jessealama wants to merge 4 commits into
jessealama wants to merge 4 commits into
Conversation
jessealama
requested review from
SamuelSchlesinger,
arademaker,
chenson2018,
crei,
fmontesi and
sorrachai
as code owners
October 27, 2026 13:39
chenson2018
requested changes
Oct 27, 2026
Collaborator
|
As previously noted, it would be appreciated when making these PRs to note the changes in performance when accepting |
Contributor
Author
|
I've did a bit of profiling and added the numbers to the PR description. Looks like it's a wash for these proofs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take care of the linter messages from the weekly linting report.
Profiling results against
main(mean of 5 runs):vm_ltsD_ltsND_not_bisim: 41 ms → 43 ms (1029 → 1110 heartbeats)exists_full_synthesis_finset: 70 ms → 50 ms (1289 → 1044 heartbeats)Profiled using
set_option trace.profiler true in, heartbeats from#count_heartbeats in.