fix: log goalsAccomplished for theorems generated using elab (#15044) - #15045
Open
medovina wants to merge 1 commit into
Open
fix: log goalsAccomplished for theorems generated using elab (#15044)#15045medovina wants to merge 1 commit into
goalsAccomplished for theorems generated using elab (#15044)#15045medovina wants to merge 1 commit into
Conversation
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the definition elaborator so that a
goalsAccomplishedmessage will be logged for theorems that were generated usingelab. That causes VS Code to display a double checkmark beside such theorems.The fix works because when
logGoalsAccomplishedSnapshotTaskis called fromelabMutualDef, thedefsParsedSnapargument contains no definitions if we are in a context without a snapshot, which happens when theorems are generated usingelab. That argument is used to determine whether anexampleis of typeProp, in which case agoalsAccomplishedmessage should be logged for it. With this fix, ifdefsParsedSnapargument has no definitions then we will send agoalsAccomplishedmessage for everyexample. As a consequence, if anexampleis generated usingelabbut is not of typeProp, it will get a checkmark in the IDE anyway. That is imperfect, however that situation should be be quite rare.Closes #15044