Repository navigation
Desk: no probe of 127.0.0.1 until paired or asked; pairing row fits a phone - #16
Merged
Merged
Conversation
… unpaired page never knocks on 127.0.0.1; the pairing row fits a phone Opening Settings on any device probed 127.0.0.1:8475, which logged a refused connection (failing verify-history and verify-phone) and could set off the browser's local-network prompt for people who never use the helper. Unpaired, it now waits for Look for it or a port typed. The pairing row's inputs may shrink below their placeholder's width, which held it 35 px wider than a 390 px phone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #14, from two regressions #15's delegate found.
Changes
127.0.0.1:8475/helloevery time Settings opened, on every device, whether or not a helper had ever been set up. That logged a refused connection:verify-historyandverify-phonefailed their page-error checks. It could also make the browser ask about local-network access for people who never use the helper. Now only a paired page looks on its own; an unpaired one waits for Look for it or for a port to be typed. The status starts as "Not looked for yet"..keyword-add .inputgetsmin-width: 0, so the long placeholder no longer holds the row 35 px wider than a 390 px screen.verify-desk.tsnow checks that an unpaired Settings page staysunchecked(it makes no request), then finds the helper when the port is typed, as before.Verified (fresh demo hubs; web built inside the worktree)
bun run typecheckandbun run testpass in every package.verify-desk: all passed.verify-history --adversarial: all ok, no page errors.verify-phone: the Settings overflow check passes. Its only failure is the.profile-scrollcheck, already failing on main; Perf: scoped renders, memoised rows and messages, and a window on long timelines #15 fixes it.🤖 Generated with Claude Code