Conversation
Use a public GitHub application credential with PKCE, reveal and validate the complete token request, and remove the confidential token service. Preserve bearer privacy, notary authenticity checks on the ledger, and the existing link-proof statement. Assisted-by: GPT-5 Signed-off-by: Wondertan <hlibwondertan@gmail.com>
Delete obsolete requirement and assumption markers rather than retaining withdrawn entries. Leave remaining identifiers and active protocol rules unchanged. Assisted-by: GPT-5 Signed-off-by: Wondertan <hlibwondertan@gmail.com>
This was referenced Sep 17, 2026
Replace undefined charset references with the existing client identifier and PKCE rules, and distinguish complete form validation from local code and redirect comparisons. Assisted-by: GPT-5 Signed-off-by: Wondertan <hlibwondertan@gmail.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
libid | 86de77a | Sep 18 2026, 04:28 PM |
Contributor
|
One clause of REQ-PLAT-61 is trimmed in #43 (stacked here), decided with Green today: the Platform Verifier holds the body's shape and the serializer's alphabet and reads no value it does not use, so the UTF-8 rule on |
xgreenx
changed the base branch from
specs/token-request-reveals-its-headers
to
main
September 21, 2026 23:10
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make GitHub a public-client PKCE profile: the browser Prover performs both notarizations, and the token attestation reveals the complete request, including the intentionally public application credential.
Rationale
GitHub explicitly documents public clients shipping their client secret and recommends PKCE. Hiding that public value in the attestation adds no confidentiality benefit. Full disclosure plus complete form validation removes the opaque request suffix without changing the link-proof statement.
The security discussion records the accepted, unquantified credential-abuse/availability risk; it does not claim that public credentials authenticate the caller or that GitHub guarantees abuse isolation.
Review boundaries
Based on #31 to retain its latest HTTP/JSON framing rules; this PR changes only the GitHub profile, shared assumptions, and their tests. Companion #13 owns the public configuration/CCDP credential plumbing, Bridge endpoint removal, and event/CSP cleanup. Implementation #28 and other implementation repositories follow separately; this is documentation only, with no rollout machinery or draft-version bump.
Rendered documents: GitHub profile, common ceremony rules, protocol overview.
Checks