fix(claim): the X token body in the profile's order, by the form serializer - #42
Merged
xgreenx merged 1 commit intoSep 20, 2026
Conversation
…alizer libid-contracts holds every token body to its profile's field list, and X's is grant_type, client_id, code, redirect_uri, code_verifier -- the order the specification's table, the Rust provers and @libid/ceremony already use. This builder put client_id last and wrote the body with encodeURIComponent, which is not the form serializer the verifier expects. Assisted-by: Claude Fable 5.1 Signed-off-by: xgreenx <xgreenx9999@gmail.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
libid | e518781 | Sep 20 2026, 08:46 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #28. libid-contracts#47 holds every token body to its profile's field list on chain. X's is
grant_type, client_id, code, redirect_uri, code_verifier: the specification's table, the Rust provers, both fixtures and@libid/ceremonyon this branch already emit it. The legacy@libid/claimX worker, still used byts/apps/demo, was the one composer that did not.Changes
ts/packages/claim/src/x/prover.worker.ts: the five fields in profile order, serialized byURLSearchParamsinstead ofencodeURIComponent, which is a URI encoder and spells a space and!~'()differently from the form serializer the verifier checks against.Verified
@libid/claimtypecheck and vitest, workspacebiome lintandbiome format: clean.Not verified / known issues
@libid/ceremonyis the builder that will be qualified. Draft so feat(ceremony): implement browser identity ceremonies #28 can absorb it.🤖 Generated with Claude Code