emuscv: correct the core's documentation page - #1197
Open
MaaaX-EPOCH84 wants to merge 1 commit into
Open
MaaaX-EPOCH84 wants to merge 1 commit into
MaaaX-EPOCH84 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am the author of the EmuSCV core. The page carried five factual errors, one of which tells users a working feature does not work.
States were marked unsupported. Save states work, and so do rewind and fast forward. This is the one that matters: users were told to expect nothing.
Sample rate read 48000/00 Hz. The core runs at 44100.
Base width and height were given as 960x720, which no setting produces. The frame buffer depends on the RESOLUTION and DISPLAY options; the six real sizes are listed instead.
Three core options were documented out of ten, and the description attached to CONSOLE ("forced sleep in main thread for lower CPU use") came from another core. All ten are now described.
One BIOS filename was missing from the list of six the core accepts, upd7801.s01.
The Not Finished marker is dropped, and the .cart format is explained, since users otherwise wonder why a new file appears in their save directory after every launch.