Expose former_temporary_channel_id and pathfinding sync timestamp - #270
Open
elnafateh wants to merge 1 commit into
Open
Expose former_temporary_channel_id and pathfinding sync timestamp #270elnafateh wants to merge 1 commit into
elnafateh wants to merge 1 commit into
Conversation
|
I've assigned @benthecarman as a reviewer! |
benthecarman
requested changes
Sep 2, 2026
| // | ||
| // Will be `None` if background pathfinding score syncing isn't configured, or no scores have | ||
| // been merged since the node was initialized. | ||
| optional uint64 latest_pathfinding_scores_sync_timestamp = 15; |
Collaborator
There was a problem hiding this comment.
in the list its now going: 7, 8, 15, 9, 10..
can you fix this
| assert!(pending_a.funding_txo.is_some()); | ||
| assert!(pending_a.reason.is_none()); | ||
| assert_eq!(pending_a.closure_initiator, ChannelClosureInitiator::Unspecified as i32); | ||
| assert!(pending_a.former_temporary_channel_id.as_deref().is_some_and(|id| !id.is_empty())); |
Collaborator
There was a problem hiding this comment.
for safety can we check that this is != to the channel id
| assert!(pending_a.funding_txo.is_some()); | ||
| assert!(pending_a.reason.is_none()); | ||
| assert_eq!(pending_a.closure_initiator, ChannelClosureInitiator::Unspecified as i32); | ||
| assert!(pending_a.former_temporary_channel_id.as_deref().is_some_and(|id| !id.is_empty())); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #251.
Adds
former_temporary_channel_idonChannelStateChanged(only set for Pending) andlatest_pathfinding_scores_sync_timestamponGetNodeInfoRespons.bolt12_invoiceis blocked because there's nobech32encoding forBolt12Invoice/StaticInvoice