Skip to content

Declare the replay 200 on createCustomer and the customer oneOf on contact-verification confirms - #1082

Draft
shreyav wants to merge 1 commit into
mainfrom
claude/awesome-davinci-zlf3oa-spec-fixes
Draft

shreyav wants to merge 1 commit into
mainfrom
claude/awesome-davinci-zlf3oa-spec-fixes

Conversation

@shreyav

@shreyav shreyav commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Two places where the server has always answered differently from the spec. POST /customers replays the original customer with 200 under a repeated Idempotency-Key, so 200 joins 201. The email and phone verification confirms answer the concrete individual or business customer, so they reference CustomerOneOf like the other customer routes instead of the Customer base.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KYyhvyVNjMMDrKJqFriCE7


Generated by Claude Code

…ntact-verification confirms

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KYyhvyVNjMMDrKJqFriCE7
@mintlify

mintlify Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
Grid 🟢 Ready View Preview Sep 26, 2026, 1:00 AM

@greptile-apps

greptile-apps Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

This PR does not match any of the 3 configured review trigger rules.

@vercel

vercel Bot commented Sep 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
grid-cards-demo Ignored Ignored Sep 26, 2026 12:59am UTC
grid-flow-builder Ignored Ignored Sep 26, 2026 12:59am UTC
grid-wallet-demo Ignored Ignored Sep 26, 2026 12:59am UTC

Request Review

@github-actions github-actions Bot added the breaking-change Introduces a breaking change to the OpenAPI spec label Sep 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Breaking OpenAPI changes detected

oasdiff reports 10 error / 22 warning changes to openapi.yaml.
This PR will need approval from an API reviewer before merge.

Errors (10)

  • POST /customers/{customerId}/verify-email/confirm — added #/components/schemas/IndividualCustomer, #/components/schemas/BusinessCustomer to the response body oneOf list for the response status 200 [response-body-one-of-added].
  • POST /customers/{customerId}/verify-email/confirm — the response's body type/format changed from object/to/`` for status 200 [response-body-type-changed].
  • POST /customers/{customerId}/verify-email/confirm — removed the required property customerType from the response with the 200 status [response-required-property-removed].
  • POST /customers/{customerId}/verify-email/confirm — removed the required property platformCustomerId from the response with the 200 status [response-required-property-removed].
  • POST /customers/{customerId}/verify-email/confirm — removed the required property umaAddress from the response with the 200 status [response-required-property-removed].
  • POST /customers/{customerId}/verify-phone/confirm — added #/components/schemas/IndividualCustomer, #/components/schemas/BusinessCustomer to the response body oneOf list for the response status 200 [response-body-one-of-added].
  • POST /customers/{customerId}/verify-phone/confirm — the response's body type/format changed from object/to/`` for status 200 [response-body-type-changed].
  • POST /customers/{customerId}/verify-phone/confirm — removed the required property customerType from the response with the 200 status [response-required-property-removed].
  • POST /customers/{customerId}/verify-phone/confirm — removed the required property platformCustomerId from the response with the 200 status [response-required-property-removed].
  • POST /customers/{customerId}/verify-phone/confirm — removed the required property umaAddress from the response with the 200 status [response-required-property-removed].

Warnings (22)

Show sample
  • POST /customers/{customerId}/verify-email/confirm — removed the optional property agreementConsents from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-email/confirm — removed the optional property contactVerification from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-email/confirm — removed the optional property createdAt from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-email/confirm — removed the optional property currencies from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-email/confirm — removed the optional property email from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-email/confirm — removed the optional property endUserTermsConsent from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-email/confirm — removed the optional property id from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-email/confirm — removed the optional property isDeleted from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-email/confirm — removed the optional property phoneNumber from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-email/confirm — removed the optional property region from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-email/confirm — removed the optional property updatedAt from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-phone/confirm — removed the optional property agreementConsents from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-phone/confirm — removed the optional property contactVerification from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-phone/confirm — removed the optional property createdAt from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-phone/confirm — removed the optional property currencies from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-phone/confirm — removed the optional property email from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-phone/confirm — removed the optional property endUserTermsConsent from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-phone/confirm — removed the optional property id from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-phone/confirm — removed the optional property isDeleted from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-phone/confirm — removed the optional property phoneNumber from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-phone/confirm — removed the optional property region from the response with the 200 status [response-optional-property-removed].
  • POST /customers/{customerId}/verify-phone/confirm — removed the optional property updatedAt from the response with the 200 status [response-optional-property-removed].

Detected by oasdiff. Full report: job summary or the oasdiff-report artifact.

This branch was successfully deployed

1 active deployment
staging - mintlify — bb5306bd Deployed Sep 26, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Introduces a breaking change to the OpenAPI spec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants