Repository navigation
Conversation
iinuwa
self-requested a review
July 29, 2026 21:21
Member
|
Thank you for pulling this together! I'm sorry for taking so long to get back to you. I thought about this, and I think that I'll want #88 to land before this one. I'll leave this PR open and come back to it once that's done. |
Member
|
@NyCodeGHG, I took the ideas from this PR and reimplemented them in #242. Some reasons for that: I didn't want to take another (albeit small) dependency on zbus-systemd for a fairly small API surface, and I wanted more modularity in the use of systemd in case someone later wanted to add systemd as an optional feature, it is more straightforward. I've given you co-author credit on the other PR, thanks for your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify xdg-deskop-portal's identity by checking systemd's dbus api to verify it's part of xdg-desktop-portal.service