Add NovaCustom V560TU board

[mkopec]

Add NovaCustom V560TU (16") laptop.

This machinee is based on the Meteor Lake platform and has integrated graphics. The dGPU variant nor the 14" variant is not supported at this point.

coreboot-dasharo revision is bumped for V560TU support and support for PR0 lockdown by Heads. The base coreboot release is 24.02.1.

Since the NV4x and NS5x boards use the same coreboot rev, their defconfigs are refreshed, too.

[macpijan]

@mkopec Do we plan to add here the rest of the variants as well?

[mkopec]

@macpijan sure, after one starts working I'll do the rest too

[tlaurion]

@macpijan @mkopec similar commit needed for #1835

[tlaurion]

@mkopec this comment might be helpful #1835 (comment)

[tlaurion]

@mkopec

mkc: seems like kernel 6.7+ is bare minimal for meteor lake, with efifb fixes having landed under 6.8+?

Also, if you pass serial to kernel boot options under coreboot config, you should get logs of the kernel?

At https://matrix.to/#/!pAlHOfxQNPXOgFGTmo:matrix.org/$bVtsV3M_sz0MroFsDkXRGQ3ow7OhumKqtAllchkAyKs?via=matrix.org&via=nitro.chat&via=envs.net

[mkopec]

mkc: seems like kernel 6.7+ is bare minimal for meteor lake, with efifb fixes having landed under 6.8+?

possible, in Ubuntu and Fedora we found it best to have Linux 6.8 or newer (6.9 also has a fix for s0ix but that's irrelevant for Heads)

@tlaurion do you think you can help with updating the kernel?

[tlaurion]

I read that 6.12 will be next Lts but that is only speculation.

edit: We choose 6.11.9 for all novacustom boards?
I can give it a shot, yes, and leave traces in commit, taking this PR state as a base.

@mkopec did serial console passed per coreboot config to kernel gave you more info?
With debug as well. See qemu coreboot config, non-prod.

[tlaurion]

@mkopec there is a lot to tune under 6.11.9 kernel config which writes over shared linux config with other novacustom (config/linux-nitrokey-x.config, should probably renamed and all board configs point to new name as well).

See branch https://github.com/tlaurion/heads/tree/dasharo-add_novacustom_v540tu and feel free to steal adapt/change whatever. If you have questions, poke me where/if needed.

Note: compare config changes in commit 510bc6e to see all the new olddefconfig stuff applied silently when using defconfig. Ie, what happened with TRUST_CPU and so many other stuff to care about once you have something that boots.

See also that I changed your coreboot config to pass linux kernel options to be in debug, with probably wrong serial ttyS0, adapt accordingly and keep me posted. Small iterations in board porting has known good track history.

If you decided to tackle #1835 instead, I could help (if you guide me into how you get serial console output [even though this work wasn't planned nor in my plate up to now]).

[tlaurion]

• Switched x230 to use 6.11.9 with same process applied for quick testing: success (no brick bumped to 6.11.9).
• building all boards that were depending on linux-x230-maximized.config with kernel 6.11.9 at https://github.com/tlaurion/heads/tree/dasharo-add_novacustom_v540tu_regression-test-on-x230_success-build_test_for_all_x230_dependent_linux_config_from_CI (expecting sandy bridge based boards to fail because bzImage will be too big)

Edit:yep. Cannot bump Sandy to 6.11.9: as can be seen, all those do not have enough free spi space without another phase of #590 (not planned.)

[mkopec]

Thanks for the patches @tlaurion , I'm testing them now, i'm not getting a serial console yet, I suspect the LPSS UART driver is missing, will try to fix

[tlaurion]

@mkopec #1865 merged, please rebase

[tlaurion]

Thanks for the patches @tlaurion , I'm testing them now, i'm not getting a serial console yet, I suspect the LPSS UART driver is missing, will try to fix

@mkopec This needs updates, since reported off-channel to be all good :)

[mkopec]

@tlaurion rebased

[tlaurion]

@mkopec awesome!!!

---

Trying to dodge politic issues from #1818 (comment) and going practical and specific.

@macpijan @mkopec : Can https://review.coreboot.org/c/coreboot/+/85278 be added to Dasharo fork (which nv41/ns50/v540TU/v560TU should build upon (modules/coreboot dasharo pointed commit), tested against #1818 so that we can merge #1818 (which changes configs for nv41) and here changes needed for PR0 for v540TU/V560TU?

Makes sense? Otherwise patches need do be under patches/coreboot-dasahro-unreleased, which I do not want to maintain since we talk of a new coreboot release.

Also, MSI(#1753 should build from same coreboot Dasharo fork commit pointed under modules/coreboot without breaking (otherwise multiple coreboot Dasahro forks will be built under Heads???? Is that the plan because multiple forks for different boards under Dasharo?)

cc @pietrushnic @macpijan

[tlaurion]

@mkopec this is shared between MSI/nv41/ns50/v540Tu/v560TU: tested for oldconfig expension/run time regression? #1818 related patch inclusion?

[mkopec]

It's not regression tested yet, will report here with results

[tlaurion]

Was 6.11.9 verified needed for meteor lake as opposed to 6.1.8 which all other Heads boards depend on after serial console issue being fixed and ACPI related Kconfig addition under linux config added that was the cause of linux hang, maybe not efifb nor 6.1.8?

[mkopec]

The cause of hang was X2APIC not being enabled in kernel config, now with that sorted I think I can try 6.1 again to check if we need 6.11 after all

[tlaurion]

Any news on this @mkopec ?

[mkopec]

Removed 6.11.9 leftovers in 313e38a

[tlaurion]

Some patches against linux were removed and not readded with adaptation as compared to 6.1.8. If 6.11.9 required for meteor lake, missing patches need to be brought back if still needed

[tlaurion]

@mkopec Review dropped :)

[tlaurion]

@mkopec I decided to not do politics in words, but as code from now on. What is coreboot fork related will be coreboot fork related from now on.

#1818 was merged, if you rebase from/merge master in your PR, you will see that added PR0 patch under patches/coreboot-dasharo_unreleased don't apply as for nv4x_adl on master, where only ns50/n4x_adl were the only Heads master consumers of Dasharo forks, showing problem of having multiple forks for different platforms and delegating problem to whom it belongs, making sure patches/coreboot-dasharo_unreleased patches that were pending next downsteam fork release are picked up/adtapted in next downstream release, and for Heads to take for granted that coreboot base is working as expected for Heads to do its Heads stuff.

• modify build/x86/coreboot-dasharo/.canary to add random character in commit id there so that fork is pulled clean
• see patches/coreboot-dasahro_unreleased dir patches reapplied on fork
• see that PR0 patch fails applying until adapted.
• adapt patch to dasharo fork, modify modules/coreboot to point to new commit
• select needed changes from WiP: PR0 (SPI write prevention through chipset locking) for nv4x_adl, setting base for other platforms/downstream forks supporting >=Skylake+ #1818 for nv4x for v540TU (board config and coreboot config)
• test
• done

I will then participate/help adapting changes to coreboot configs/board configs if needed for Heads under #1868, which points to needed knowledge for Heads for PR0 to work as expected on skylake+, and will be used as base so coreboot upstream patch evolves to be useful for all and prevent OS persistent threat to be pushed to firmware (at least under Heads use case) leaving physical attack of tampering bootblock the only threat model to SPI flash for advanced users activating Heads Authenticated Heads, which I intend to push on next feature freeze (next downstream release).

[mkopec]

nv4x and ns5x restored, moved back to using a single coreboot revision for all clevo boards

[tlaurion]

nv4x and ns5x restored, moved back to using a single coreboot revision for all clevo boards

Alright, https://github.com/linuxboot/heads/compare/a80d6da99ba15fa9d1462e084c9065b4ec3c8e9f..b59c0e2e3369a87b1f84ddad887dd821268c7e57 looks sane.

Waiting for @jans23 @nestire @daringer to confirm no regression. Off channel response was for next week,
@mkopec @macpijan @BeataZdunczyk : We could also remove ns50 from Heads master at this point, too, using helpers to move to UNTESTED, as it was the case under Heads for all untested boards, and leaving Nitrokey to create PR when the board will be tested and confirmed without regression.

Blockers here are affecting #1875 as well, since v560tu is not under master, and required changes for v560tu under #1875 are not there nor testing possible for that platform, which Nitrokey is also expecting to work (for Christmas per blob post).

What do we do? I have no problem dropping ns50, which Nitrokey supports with their fork and rebranding as of now. I have no testers for ns50 under https://github.com/linuxboot/heads/blob/master/BOARD_TESTERS.md which is also problematic. If a board is untested, it should be marked as such and we should move forward.

[tlaurion]

nv4x and ns5x restored, moved back to using a single coreboot revision for all clevo boards

Alright, https://github.com/linuxboot/heads/compare/a80d6da99ba15fa9d1462e084c9065b4ec3c8e9f..b59c0e2e3369a87b1f84ddad887dd821268c7e57 looks sane.

Waiting for @jans23 @nestire @daringer to confirm no regression. Off channel response was for next week, @mkopec @macpijan @BeataZdunczyk : We could also remove ns50 from Heads master at this point, too, using helpers to move to UNTESTED, as it was the case under Heads for all untested boards, and leaving Nitrokey to create PR when the board will be tested and confirmed without regression.

Blockers here are affecting #1875 as well, since v560tu is not under master, and required changes for v560tu under #1875 are not there nor testing possible for that platform, which Nitrokey is also expecting to work (for Christmas per blob post).

What do we do? I have no problem dropping ns50, which Nitrokey supports with their fork and rebranding as of now. I have no testers for ns50 under https://github.com/linuxboot/heads/blob/master/BOARD_TESTERS.md which is also problematic. If a board is untested, it should be marked as such and we should move forward.

user@heads-tests-deb12-nix-V560TU:~/heads$ ./docker_repro.sh make BOARD=nitropad-ns50 board.move_tested_to_untested
Using CircleCI Docker image: tlaurion/heads-dev-env:v0.2.4
----
Usage reminder: The minimal command is 'make BOARD=XYZ', where additional options, including 'V=1' or 'CPUS=N' are optional.
For more advanced QEMU testing options, refer to targets/qemu.md and boards/qemu-*/*.config.

Type exit within docker image to get back to host if launched interactively!
----

--->Launching container without access to host's USB buses (no USB devices was connected to host)...
----------------------------------------------------------------------
!!!!!! BUILD SYSTEM INFO !!!!!!
System CPUS: 12
System Available Memory: 16867 GB
System Load Average: 0.00
----------------------------------------------------------------------
Used **CPUS**: 12
Used **LOADAVG**: 18
Used **AVAILABLE_MEM_GB**: 16866 GB
----------------------------------------------------------------------
**MAKE_JOBS**: -j12 --load-average=18 

Variables available for override (use 'make VAR_NAME=value'):
**CPUS** (default: number of processors, e.g., 'make CPUS=4')
**LOADAVG** (default: 1.5 times CPUS, e.g., 'make LOADAVG=54')
**AVAILABLE_MEM_GB** (default: memory available on the system in GB, e.g., 'make AVAILABLE_MEM_GB=4')
**MEM_PER_JOB_GB** (default: 1GB per job, e.g., 'make MEM_PER_JOB_GB=2')
----------------------------------------------------------------------
!!!!!! Build starts !!!!!!
Makefile:270: warning: overriding recipe for target 'all'
Makefile:251: warning: ignoring old recipe for target 'all'
NEW_BOARD variable will add UNTESTED_ prefix to nitropad-ns50
changing nitropad-ns50 name under boards/nitropad-ns50/nitropad-ns50.config to UNTESTED_nitropad-ns50
sed: can't find label for jump to `oards/nitropad-ns50/nitropad-ns50.config'
Renaming boards/nitropad-ns50/nitropad-ns50.config to boards/nitropad-ns50/UNTESTED_nitropad-ns50.config
Renaming boards/nitropad-ns50 to boards/UNTESTED_nitropad-ns50
Replacing nitropad-ns50 with UNTESTED_nitropad-ns50 in .circleci/config.yml

[tlaurion]

@macpijan @mkopec @BeataZdunczyk @jans23 @nestire @daringer I advise cherry-picking tlaurion@d70b01d and merging this PR so that #1875 moves forward.

[macpijan]

Sounds good to us.

IIUC NS50 can be always moved back from UNTESTED - this will let us move forward here, and do not put pressure on NK if not priority at this moment.

[tlaurion]

Sounds good to us.

IIUC NS50 can be always moved back from UNTESTED - this will let us move forward here, and do not put pressure on NK if not priority at this moment.

@mkopec I apply my maintainer veto here. Please cherry-pick, let's wait for Ci to build, and merge this PR.

[macpijan]

Michał is offline already. I have cherry-picked I hope I have done it correctly.

[tlaurion]

Oh @macpijan

Who should I add for v560tu under https://github.com/linuxboot/heads/blob/master/BOARD_TESTERS.md ?

(Can be added later after merge of this PR)

[macpijan]

You can add @mkopec and me as a backup/contact right now.

[tlaurion]

• test nv41's https://output.circle-artifacts.com/output/job/e5f3b4b7-8d9e-41fc-afe1-7d58fad56747/artifacts/0/build/x86/novacustom_nv4x_adl/heads-novacustom_nv4x_adl-v0.2.0-2500-geee5039.zip (PR0 works)
• merge

[tlaurion]

Sorry, @mkopec : I haven't seen Dasharo/coreboot#609 that was supposed to be merged before this PR, which is now #1889