fix(core): drop matches that overlap any earlier kept match in tokenize - #1460
Closed
RaphaelFakhri wants to merge 1 commit into
Closed
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
RaphaelFakhri
requested review from
1egoman,
lukasIO and
thomasyuill-livekit
as code owners
September 29, 2026 10:02
🦋 Changeset detectedLatest commit: 0f0fe49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@RaphaelFakhri is attempting to deploy a commit to the LiveKit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tokenizeremoves overlapping matches by comparing each match with the previous entry in the sorted list, not with the last match it kept. When a long match contains two or more shorter matches, the first nested match is dropped but the second one starts after it ends, so it passes the check. The output then contains the nested text a second time.For the grammar
{ outer: /abcdefghij/g, first: /cd/g, second: /gh/g }and the inputxx abcdefghij yy, the tokens join toxx abcdefghijghij yy.This change tracks the end of the last kept match and drops any match that starts before it.
Testing
tokenizer.test.tswith a basic split case and two overlap cases.mainand pass with this change.Changeset
Adds a patch changeset for
@livekit/components-core.