fix(server-sdk): keep canPublishSources intact when encoding a token - #737
Closed
RaphaelFakhri wants to merge 1 commit into
Closed
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: aeab982 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
claimsToJwtPayloadshallow-copies the claims and then assigns the convertedcanPublishSourcesonto the sharedvideoobject. After the firsttoJwt(), the token's grants hold strings such as'camera'instead ofTrackSourcevalues, and the secondtoJwt()throwsCannot convert TrackSource camera to string.This change builds a new
videoobject for the payload so the token's grants are left as they were.Testing
Added a test in
grants.test.tsthat converts the same claims twice and checks the input is unchanged, and a test inAccessToken.test.tsthat callstoJwt()twice and verifiescanPublishSourcesin both tokens.Command:
pnpm prebuild && npx vitest run src/grants.test.ts src/AccessToken.test.tsinpackages/livekit-server-sdk.A patch changeset for
livekit-server-sdkis included.