feat(e2e): authorize fork comment checks - #271
Draft
vcauesantos wants to merge 4 commits into
Draft
vcauesantos wants to merge 4 commits into
vcauesantos wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
comment-triggered-checkpull_requestworkflowSecurity
The privileged
issue_commentworkflow never checks out fork code. For an approved fork request, it records the parsed command and toggles an internal label with a GitHub App or PAT token. Apull_request: labeledworkflow accepts only the trusted bot's request for the pull request's exact head SHA.This preserves the normal pull request cache scope and avoids dispatching the base branch before checking out fork code.
Testing
make test-comment-triggered-check(188 passed)shellcheck -x .github/actions/comment-triggered-check/src/*.shmake check-docsPart of DEVOPS-1541.
After merge,
comment-triggered-check/v1must be advanced before the caller PRs can merge.