Skip to content

fix(ci): stabilize required dashboard-browser goal-hierarchy shard #6890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 1 commit into from
Oct 20, 2026
Merged

fix(ci): stabilize required dashboard-browser goal-hierarchy shard #6890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions examples/personal-workspace-browser/goal-hierarchy.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,16 @@ export const goalHierarchyScenario = {
const root = await mkdtemp(join(tmpdir(), "loopx-goal-tree-"));
let owner, ownerB, context, denied = false;
const statusReads = [];
const subtreeGoalIds = ["calibration", "graph", "portfolio", "research"];
let inFlightStatusReads = 0;
const waitForStatusReads = async (expected, description) => {
const deadline = Date.now() + 15_000;
while (Date.now() < deadline) {
if (inFlightStatusReads === 0 && expected.every(id => statusReads.includes(id))) return;
await new Promise(resolve => setTimeout(resolve, 25));
}
throw new Error(`timed out waiting for ${description}; reads=${JSON.stringify(statusReads)}; in_flight=${inFlightStatusReads}`);
};
const captures = [
["research", "Research · synthetic"],
["portfolio", "Portfolio", "research"],
Expand Down Expand Up @@ -63,13 +73,18 @@ export const goalHierarchyScenario = {
status: 200,
}));
await page.route(target => target.pathname === "/status.json", async route => {
const selected = new URL(route.request().url()).searchParams.get("goal_id");
if (selected) statusReads.push(selected);
if (denied && new URL(route.request().url()).searchParams.get("goal_id") === "graph") {
return route.fulfill({status: 403, json: {ok: false, error_code: "workspace_status_access_denied"}});
inFlightStatusReads += 1;
try {
const selected = new URL(route.request().url()).searchParams.get("goal_id");
if (selected) statusReads.push(selected);
if (denied && new URL(route.request().url()).searchParams.get("goal_id") === "graph") {
return route.fulfill({status: 403, json: {ok: false, error_code: "workspace_status_access_denied"}});
}
const response = await fetchWorkspaceBackend(route, owner.base);
await route.fulfill({response});
} finally {
inFlightStatusReads -= 1;
}
const response = await fetchWorkspaceBackend(route, owner.base);
await route.fulfill({response});
});
await page.route(`${ownerB.base}/status.json*`, async route => {
const response = await fetch(route.request().url());
Expand Down Expand Up @@ -98,13 +113,15 @@ export const goalHierarchyScenario = {
assert.equal(await row("portfolio").count(), 0, "Children start folded on the ordinary workspace");
for (const id of ["daily", "orphan", "cycle-a", "cycle-b"]) await row(id).waitFor();
await page.screenshot({path: resolve(outputDir, "goal-hierarchy-overview.png"), animations: "disabled"});
await waitForStatusReads(captures.map(([id]) => id), "initial workspace reads");
await page.waitForLoadState("networkidle");
statusReads.length = 0;
await row("research").locator(".personal-goal-link").click();
await page.getByRole("button", {name: "只看此 Goal 及子 Goal", exact: true}).click();
await page.waitForURL(target => target.searchParams.get("rootGoalId") === "research");
assertResearchFocus();
await row("portfolio").waitFor();
await waitForStatusReads(subtreeGoalIds, "scoped subtree reads");
await page.waitForLoadState("networkidle");
assert(statusReads.every(id => ["calibration", "graph", "portfolio", "research"].includes(id)),
"reusing loaded subtree snapshots must not open unrelated Goal state");
Expand All @@ -113,8 +130,10 @@ export const goalHierarchyScenario = {
await row("portfolio").getByRole("button", {name: "展开子 Goal：Portfolio", exact: true}).focus();
await page.keyboard.press("Enter");
await row("calibration").locator(".personal-goal-link").click();
await waitForStatusReads([], "status reads before reload");
statusReads.length = 0;
await page.reload({waitUntil: "networkidle"});
await waitForStatusReads(subtreeGoalIds, "reloaded subtree reads");
await row("calibration").locator('[aria-current="page"]').waitFor();
assert.deepEqual([...new Set(statusReads)].sort(), ["calibration", "graph", "portfolio", "research"],
"opening a scoped workspace reads its recursive subtree without opening unrelated Goal state");
Expand Down
Loading