[proj] I2C D1 sign-off - #705
Merged
Merged
Conversation
Collaborator
Author
|
Closes #493 |
Closed
marnovandermaas
approved these changes
Sep 8, 2026
marnovandermaas
left a comment
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
One comment but otherwise this looks good to me. We should wait for 3 approvers before merging this.
tchilikov-semify
force-pushed
the
d1_signoff_i2c
branch
from
September 8, 2026 09:01
10a9656 to
2e8ee3b
Compare
martin-velay
reviewed
Sep 9, 2026
tchilikov-semify
force-pushed
the
d1_signoff_i2c
branch
from
September 10, 2026 10:47
2e8ee3b to
f1e1728
Compare
tchilikov-semify
marked this pull request as draft
September 10, 2026 10:49
tchilikov-semify
force-pushed
the
d1_signoff_i2c
branch
from
September 10, 2026 11:23
f1e1728 to
d3ec955
Compare
tchilikov-semify
marked this pull request as ready for review
September 10, 2026 14:41
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Sep 11, 2026
Add the D1 design sign-off checklist for the I2C and move it to D1 in the stage table.
tchilikov-semify
force-pushed
the
d1_signoff_i2c
branch
from
September 11, 2026 10:08
d3ec955 to
8257c76
Compare
tchilikov-semify
enabled auto-merge
September 11, 2026 10:09
tchilikov-semify
disabled auto-merge
September 11, 2026 10:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the D1 design sign-off checklist for the I2C and move it to D1 in the stage table.