[kmac] add missing output known assertions - #720
Merged
marnovandermaas merged 1 commit intoSep 10, 2026
Merged
Conversation
app_o, entropy_o and idle_o had no ASSERT_KNOWN. idle_o is a registered mubi4 and entropy_o is driven from a synchroniser or tied off, so both are always known; app_o holds up unconditionally too. The vendored source is patched in place and the change is recorded in 0005-Add-missing-output-known-assertions.patch. kmac_smoke passes 3/3 with Xcelium in both the unmasked and masked configurations. Fixes lowRISC#707
marnovandermaas
approved these changes
Sep 10, 2026
marnovandermaas
left a comment
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me!
marnovandermaas
enabled auto-merge
September 10, 2026 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app_o, entropy_o and idle_o had no ASSERT_KNOWN. idle_o is a registered mubi4 and entropy_o is driven from a synchroniser or tied off, so both are always known; app_o holds up unconditionally too.
The vendored source is patched in place and the change is recorded in 0005-Add-missing-output-known-assertions.patch.
kmac_smoke passes 3/3 with Xcelium in both the unmasked and masked configurations.
Closes #707