Repository navigation
Backport module-state eviction crash fix - #8
Open
4genealogic-filmset wants to merge 1 commit into
Open
4genealogic-filmset wants to merge 1 commit into
4genealogic-filmset wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bazel 9.2.9993 crashes while evaluating overridden MODULE.bazel files when memory pressure evicts Skyframe compute state between two lookups. This signature accounted for 11 of 16 internal-crash failures in the 72-hour infrastructure audit.
Backport upstream #30756 (acccb6e): pass the caller's existing State into execNonRegistryModuleFile for both root and non-root modules, eliminating the second lookup that can return empty state.
Based on
449456745b83d5ec3e270af623e0b9cc189d5a3e, the tip of9.2.0-with-backported-fixesand deployed release9.2.9993, preserving the existing Lucid backports.Validation: all 66 ModuleFileFunctionTest cases passed in a separate checkout of that exact base with the identical patch; git diff --check passed. A new fork release and main repository version-pin update will be needed after merge to verify the fix in CI.