Skip to content

[GIT-351] chore: flatten web components out of core/ - #9883

Merged
sriramveeraghanta merged 1 commit into
previewfrom
chore/git-351-flatten-web-components
Sep 28, 2026
Merged

sriramveeraghanta merged 1 commit into
previewfrom
chore/git-351-flatten-web-components

Conversation

@prateekshourya29

Copy link
Copy Markdown
Member

Description

Third of four stacked PRs to flatten apps/web/core/ into the app root.

  • Move components/ from apps/web/core/ to apps/web/components/
  • Add transitional path override @/components/* (keep @/* → ./core/*)
  • Leaves apps/web/core/ empty (removed in the finalize PR)

No behavior change — path layout / alias cleanup. Domain folders like components/core are untouched.

Stack: targets GIT-349 branch. After lower PRs merge, rebase onto preview with --committer-date-is-author-date and retarget base to preview.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

Test Scenarios

  1. pnpm turbo run check:types --filter=web is green
  2. apps/web/components exists at the app root
  3. apps/web/core/components is gone

References

  • GIT-351
  • Parent: GIT-348
  • Depends on: GIT-349

Move apps/web/core/components to apps/web/components and add a
transitional @/components/* path override.
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Walkthrough

Warning

Review details and warnings were omitted to fit the comment limit.

@makeplane

makeplane Bot commented Sep 25, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

React Doctor found 1 new issue in 1 file · 1 warning · score 63 / 100 (Needs work) · 0 fixed · vs preview

1 warning

components/settings/profile/sidebar/item-categories.tsx

  • ⚠️ L61 Control missing accessible label control-has-associated-label

Reviewed by React Doctor for commit 681d45f. See inline comments for fixes.

@prateekshourya29
prateekshourya29 force-pushed the chore/git-349-flatten-web-hooks-store branch from 0f49956 to a5ecc34 Compare September 25, 2026 11:51
@prateekshourya29
prateekshourya29 force-pushed the chore/git-351-flatten-web-components branch from 4de11fe to bcf7a46 Compare September 25, 2026 11:51
Base automatically changed from chore/git-349-flatten-web-hooks-store to preview September 28, 2026 14:54
@prateekshourya29
prateekshourya29 force-pushed the chore/git-351-flatten-web-components branch from bcf7a46 to 681d45f Compare September 28, 2026 14:57
@sriramveeraghanta
sriramveeraghanta merged commit bdebb44 into preview Sep 28, 2026
14 checks passed
@sriramveeraghanta
sriramveeraghanta deleted the chore/git-351-flatten-web-components branch September 28, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants