Skip to content

[GIT-352] chore: point web @/* at app root and remove core/ - #9884

Merged
sriramveeraghanta merged 1 commit into
previewfrom
chore/git-352-flatten-web-finalize-alias
Sep 29, 2026
Merged

sriramveeraghanta merged 1 commit into
previewfrom
chore/git-352-flatten-web-finalize-alias

Conversation

@prateekshourya29

@prateekshourya29 prateekshourya29 commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Description

Final of four stacked PRs to flatten apps/web/core/ into the app root.

  • Set @/* → ./* in apps/web/tsconfig.json
  • Drop transitional per-folder overrides and redundant @/app/*, @/helpers/*, @/styles/* entries
  • Remove empty apps/web/core/

No behavior change — path alias cleanup. Matches admin/space.

Stack: targets GIT-351 branch. After lower PRs merge, rebase onto preview with --committer-date-is-author-date and retarget base to preview.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

Test Scenarios

  1. pnpm turbo run check:types --filter=web is green
  2. apps/web/core is gone
  3. @/* resolves to the app root

References

  • GIT-352
  • Parent: GIT-348
  • Depends on: GIT-351

Summary by CodeRabbit

  • Chores
    • Updated TypeScript path resolution for the @/ alias.

Finalize the flatten: @/* → ./* , drop transitional path overrides
and redundant @/app|helpers|styles entries, remove empty core/,
and update Claude.md store path note.
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 612ecddb-c7d3-453f-89c3-e40fe8458418

📥 Commits

Reviewing files that changed from the base of the PR and between 6b7e51a and 77baec5.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 0464a9ef-a7b7-4cdd-8f80-a4f4583876f5

📥 Commits

Reviewing files that changed from the base of the PR and between 4de11fe and 6b7e51a.

📒 Files selected for processing (1)
  • apps/web/tsconfig.json

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The web TypeScript configuration changes the @/* path mapping from ./core/* to ./* and removes the specific path aliases.

Changes

Web TypeScript Path Alias

Layer / File(s) Summary
Update the path mapping
apps/web/tsconfig.json
The @/* path mapping now targets ./*. The separate aliases for layouts, lib, services, hooks, store, components, app, helpers, and styles are removed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 6b7e5

The alias change preserves the targets of current imports, so no material merge risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the TypeScript alias change and removal of the obsolete core directory.
Description check ✅ Passed The description includes all required sections, explains the alias cleanup, lists the change types, documents test scenarios, and provides references. The selected Improvement type conflicts slightly …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@makeplane

makeplane Bot commented Sep 25, 2026

Copy link
Copy Markdown

@prateekshourya29
prateekshourya29 force-pushed the chore/git-352-flatten-web-finalize-alias branch from 6b7e51a to e8adf7a Compare September 25, 2026 11:51
@prateekshourya29
prateekshourya29 force-pushed the chore/git-351-flatten-web-components branch from 4de11fe to bcf7a46 Compare September 25, 2026 11:51
@prateekshourya29
prateekshourya29 force-pushed the chore/git-352-flatten-web-finalize-alias branch from e8adf7a to da5cd04 Compare September 28, 2026 14:57
@prateekshourya29
prateekshourya29 force-pushed the chore/git-351-flatten-web-components branch from bcf7a46 to 681d45f Compare September 28, 2026 14:57
Base automatically changed from chore/git-351-flatten-web-components to preview September 28, 2026 15:01
@prateekshourya29
prateekshourya29 force-pushed the chore/git-352-flatten-web-finalize-alias branch from da5cd04 to 77baec5 Compare September 28, 2026 15:02
@sriramveeraghanta
sriramveeraghanta merged commit e53e2b6 into preview Sep 29, 2026
14 checks passed
@sriramveeraghanta
sriramveeraghanta deleted the chore/git-352-flatten-web-finalize-alias branch September 29, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants