Repository navigation
build(deps): bump certifi to 2026.10.23 - #24
Closed
man8-octoflow[bot] wants to merge 1 commit into
Closed
man8-octoflow[bot] wants to merge 1 commit into
man8-octoflow[bot] wants to merge 1 commit into
Conversation
Earlier certifi releases bundle the emSign ECC Root CA - G3 root, whose eMudhra intermediates have compromised keys and have been revoked. certifi reaches the lockfile only through requests in the dev extra, so the published package is unaffected. Produced with uv lock --upgrade-package certifi; no other package moved. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pk5H9KCpSX7PmWxKeGd9Qd
|
Important Review skippedThis PR was authored by a bot without an assigned CodeRabbit review seat. Ask an organization administrator to assign a seat to the bot. See the seat-assignment guide. After the seat is assigned, request a review again.
|
Author
|
@coderabbitai review |
Owner
|
@coderabbitai full review |
|
7 tasks done
Author
|
Superseded by #25: the same change, re-filed under a different author so that CodeRabbit reviews it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps the locked
certififrom 2025.4.26 to 2026.10.23, produced byuv lock --upgrade-package certifi.uv.lockis the only file changed, and certifi is the only package the resolver moved.Motivation and Context
Raised by Aikido. certifi releases before 2026.10.18 bundle the
emSign ECC Root CA - G3root certificate. Eight eMudhra intermediate CAs that chain to it have compromised private keys and have been revoked, so a holder of one of those keys can issue certificates that a certifi-backed client would trust for any hostname.certifi is not a dependency of the published package:
dependenciesinpyproject.tomlis empty, and certifi reaches the lockfile only transitively, throughrequestsin thedevextra. The wheel is therefore unaffected, andpyproject.tomlis unchanged; the fix is to the development and CI environment.2026.10.23 is the latest release on PyPI. It declares
requires_python >=3.7and carries the Python 3.8 classifier, so it covers the whole CI matrix (3.8 to 3.13). The sdist and wheel sha256 hashes inuv.lockmatch PyPI's, and neither file is yanked.Type of Change
How Has This Been Tested?
From the branch, each run separately, as CI invokes them, on Python 3.13:
uv sync --all-extras --dev: installedcertifi==2026.10.23uv run ruff check .: All checks passed!uv run ruff format --check .: 23 files already formatteduv run mypy src/: Success: no issues found in 2 source filesuv run pytest tests/ -v --tb=short: 153 passedChecklist
ruff checkandruff format --check)uv run pytest)uv run mypy src/)Additional Notes
CHANGELOG.mdis deliberately unchanged; the next release's changelog is prepared separately.Post-merge checks, recorded on the tracking work item's post-merge verification section:
main? Yes: theTestworkflow (Python 3.8 to 3.13) and CodeQL default-setup code scanning run on push tomain. Verify both are green on the merge commit, and thatuv.lockthere lists certifi 2026.10.23.Releaseworkflow runs only onv*tags, and nothing else deploys frommain. The scanner finding should clear oncemaincarries the new lock.🤖 Generated with Claude Code
https://claude.ai/code/session_01Pk5H9KCpSX7PmWxKeGd9Qd