Repository navigation
[Aikido] Fix security issue in urllib3 via minor version upgrade from 2.4.0 to 2.8.0 - #27
Open
aikido-autofix[bot] wants to merge 1 commit into
Open
aikido-autofix[bot] wants to merge 1 commit into
aikido-autofix[bot] wants to merge 1 commit into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade urllib3 to fix critical vulnerabilities: HTTPS proxy TLS bypass (certificate verification bypass), unbounded memory allocation in chunked transfer encoding (DoS), decompression bomb attacks (CPU/memory exhaustion), and redirect bypass enabling SSRF/open redirect attacks.
Motivation and Context
Fixes #(issue)
Type of Change
How Has This Been Tested?
Test Commands:
uv run pytest # or specific test commandTest Configuration:
Security Impact — CVE vulnerabilities fixed by this PR:
✅ 6 CVEs resolved by this upgrade
This PR will resolve the following CVEs:
Fix Details / Technical Implementation (detailed write-up of what was changed and why):
🤖 Remediation details
Fix urllib3 high/medium severity CVEs by narrowing Python floor and bumping requests
This PR remediates six CVEs in urllib3 (the only vulnerable package in scope). The urllib3 package appears as a transitive dependency via
requestsin thedevoptional-dependency group of the rootpyproject.toml, and the fix is reflected inuv.lock.urllib3
urllib3 2.8.0 (the minimum patched release covering all six advisories) requires Python ≥ 3.10. Because
requires-pythonwas set to>=3.8, the resolver created Python 3.8 and 3.9 marker forks that could not satisfyurllib3>=2.8.0, leaving two old copies (2.2.3 and 2.4.0) in the lockfile. The fix narrowsrequires-pythonfrom>=3.8to>=3.10, eliminating those forks. Additionally, the direct dev dependencyrequestswas raised from>=2.25.0to>=2.32.3so the resolver selects arequestsrelease (2.34.2) that itself requiresurllib3>=2.8.0, ensuring the patched transitive version is pulled in. After these two edits,uv lockresolves urllib3 to exactly 2.8.0 with a single lockfile instance.Version changes
>=2.25.0(resolved 2.32.3)>=2.32.3(resolved 2.34.2)Checklist
ruff checkandruff format --check)uv run pytest)uv run mypy src/)Additional Notes