Repository navigation
feat: harden capture pipeline and editor crop UX - #5
Conversation
- Add separate editor window (Vite multi-page) with timeline layout - Step delete (editor + panel) and drag-and-drop reorder (panel, @dnd-kit) - Replace standalone Discard button with New dropdown menu (New Recording / Discard All) - Redesign HTML/PDF export with modern timeline layout matching editor - Add pre-write validation (dir writable, file overwritable, disk space) - Improve export error messages with user-friendly descriptions - Close panel on editor open and after successful export - Fix editor scroll bleed behind macOS title bar (container-level scroll) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This pull request is too large for Augment to review. The PR exceeds the maximum size limit of 100000 tokens (approximately 400000 characters) for automated code review. Please consider breaking this PR into smaller, more focused changes. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4623d12d6d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| // Notify editor window (if open) that steps were discarded | ||
| let _ = app.emit("steps-discarded", ()); |
There was a problem hiding this comment.
discard_recording now emits steps-discarded and clears the session, but it never stops or clears state.pre_click_buffer (unlike stop_recording). After a user discards a recording, the ScreenCaptureKit pre-click stream can keep running in the background until the next recording/app exit, which wastes resources and keeps capture state alive while the app is idle. Add the same take()+stop() cleanup used in stop_recording to the discard path before returning.
Useful? React with 👍 / 👎.
Summary\n- harden screenshot capture + event merge behavior for fragile menu/overlay interactions\n- add editor crop reliability + drag reposition + runtime/performance hardening\n- add AI description grounding/stability improvements for multilingual and edge UI cases\n- add targeted frontend tests to satisfy strict per-file coverage pre-push gates\n\n## Verification\n- sh .githooks/pre-push.sh\n- npm run test:coverage\n- cargo clippy -- -D warnings\n- npx tsc --noEmit\n