Skip to content

fix: dedupe codex autofix by concrete review id - #8

Merged
markusleben merged 1 commit into
mainfrom
fix/codex-feedback-dedupe-review-id
Feb 16, 2026
Merged

markusleben merged 1 commit into
mainfrom
fix/codex-feedback-dedupe-review-id

Conversation

@markusleben

Copy link
Copy Markdown
Owner

Summary

  • resolve latest concrete codex review id when manual triggers omit review_id
  • key dedupe marker by concrete review id (review-<id>) instead of static fallback collisions
  • harden comment posting step to valid YAML/shell (--body-file) and avoid heredoc parse pitfalls

Why

This fixes the codex finding where /codex-fix could be blocked after one run because dedupe used a static marker when review_id was empty.

Verification

  • workflow YAML parse check
  • pre-push gate passed (clippy + coverage + tsc)

@markusleben
markusleben merged commit 358c65b into main Feb 16, 2026
3 checks passed
@markusleben
markusleben deleted the fix/codex-feedback-dedupe-review-id branch February 16, 2026 14:11

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 076ca2ef34

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fi

if [ -z "$REVIEW_ID" ]; then
REVIEW_ID=$(gh api "repos/$GITHUB_REPOSITORY/pulls/$PR/reviews" --paginate --jq '

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use --slurp when paginating review lookup

When a PR has enough reviews to span multiple API pages, gh api --paginate --jq ... can emit one selected review ID per page, so REVIEW_ID=$(...) may contain multiple newline-separated IDs instead of one. That multi-line value is then written via echo "review_id=$REVIEW_ID" >> "$GITHUB_OUTPUT", which can corrupt step outputs (or later produce an invalid pulls/<pr>/reviews/<id>/comments path), causing /codex-fix runs to fail on long-lived PRs. Collapse paginated data into a single JSON stream (e.g., --slurp) or explicitly pick one ID after pagination.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant