Show C *callables* instead of "<native>" in Tachyon - #8
Open
maurycy wants to merge 2 commits into
Open
Conversation
maurycy
commented
Aug 29, 2026
Comment on lines
+308
to
+315
| #define CALLABLE_HEADER_SIZE \ | ||
| (offsetof(PyWrapperDescrObject, d_base) + sizeof(void *)) | ||
| _Static_assert(offsetof(PyCFunctionObject, m_module) + sizeof(void *) <= | ||
| CALLABLE_HEADER_SIZE, | ||
| "PyCFunctionObject fields must fit in the callable header"); | ||
| _Static_assert(offsetof(PyMethodDescrObject, d_method) + sizeof(void *) <= | ||
| CALLABLE_HEADER_SIZE, | ||
| "PyMethodDescrObject fields must fit in the callable header"); |
Owner
Author
There was a problem hiding this comment.
We don't have debug offsets. The same comment around all offsetof occurences.
Owner
Author
|
@pablogsal Does this make directional sense to you? Please do not review this yet. This is mostly a proof concept. The prime problems are a) we don't have debug offsets here so it relies on elaborate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shortly:
numpy.dot(BLAS) etc. invisible,CALL,CALL_KWandCALL_FUNCTION_EXBINARY_OPetc.This is the result:
for: