Repin the C library, because a version requirement here is exact - #2
Merged
Conversation
Measured against the index after openkal-musl 0.6.0 was published: a manifest saying `openkal-musl = "0.5.0"` still resolves to 0.5.0. Nothing floats up, which is the property that keeps a release from moving under a consumer that did not ask --- and the consequence is that this package does not receive a fix by having one published beneath it. 0.6.0 answers three defects reported as openkal-linux#13. Two are reachable from these tools without any of them doing anything unusual: a caller that redirects a standard stream and then starts a program --- with posix_spawn, with system, or with fork and execve --- had the started program write to the stream the CALLER had been started with; and abort did not end the program at all, so an assertion failure reported a segmentation fault. `xargs` and `sh` are the tools here that start programs, and the whole suite is run by a harness that reads what each tool wrote. Nothing else changes. 0.1.2 -> 0.1.3 records which C library a consumer resolving this version is handed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measured against the index after
openkal-musl 0.6.0
was published — a manifest saying
openkal-musl = "0.5.0"still resolves to0.5.0:Nothing floats up. That is the property that keeps a release from moving under a
consumer that did not ask for it, and the consequence is that this package does
not receive a fix by having one published beneath it.
What it does not currently receive
0.6.0 answers three defects reported as
openkal-linux#13. Two are
reachable from these tools without any of them doing anything unusual:
posix_spawn, withsystem, or withforkandexecve— had the startedprogram write to the stream the caller had been started with;
abortdid not end the program. musl'sraiseistkill, the port had nocase for it, so
abortfell through toa_crash()—hlton x86_64 — and anassertion failure reported a segmentation fault.
xargsandshare the tools here that start programs, and the whole suite isrun by a harness that reads what each tool wrote.
Already measured
This repository's CI substitutes openkal-musl's default branch working tree
for the version named here, so it has been building against 0.6.0's content
since that merged. Dispatched after the merge: green, all 97 tools.
What this change adds is that a consumer resolving
sbasefrom the index getsthe same C library the CI has been testing with.
Nothing else changes.
0.1.2→0.1.3.