Fix whitespace in Algolia JSON generation - #11975
Open
MarkvanMents wants to merge 2 commits into
Open
MarkvanMents wants to merge 2 commits into
MarkvanMents wants to merge 2 commits into
Conversation
Collaborator
Author
|
[TW-2843] |
Collaborator
Author
|
Tested and updated Algolia file to Algolia. Blank text entries are no longer there. |
OlufunkeMoronfolu
added this pull request to stack #11978
September 29, 2026 12:39
After plainify strips HTML tags from heading elements, trailing \r, \n, and other whitespace remained in the h2-h6 fields because htmlUnescape alone does not trim. This caused dirty values in those fields and in the unique_hierarchy breadcrumb string. Replaced htmlUnescape with strings.TrimSpace (htmlUnescape ...) for all five heading levels. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
OlufunkeMoronfolu
force-pushed
the
MvM-BlankAlgoliaText
branch
from
September 29, 2026 12:46
bd1a2f9 to
4110b43
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trim ... " "withstrings.TrimSpacefor thetextfield to strip all Unicode whitespace including\r,\n,\t, and non-breaking spaces ( ) that were being uploaded as blank records to Algoliastrings.TrimSpacefix to all h2–h6 heading fields, which previously retained trailing whitespace in heading values and theunique_hierarchybreadcrumb stringTest plan
"text":"\r"or whitespace-only text records appear in the generated Algolia JSONunique_hierarchyvalues have no trailing whitespace🤖 Generated with Claude Code