[MOO-2490] : Patch react native vision camera to set higher resolution of image - #1339
Open
saurabhchavan1711 wants to merge 2 commits into
Open
saurabhchavan1711 wants to merge 2 commits into
saurabhchavan1711 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR Requests a higher analysis resolution than the CameraX default (640x480), so ML Kit can read barcodes on patterned backgrounds. Currently it passes default (640x480) picture to ML Kit library which does not correctly reads barcode values , also sometimes it does not get scanned as well. This fix will ask for higher resolution of 1920 x 1440 . If phone does not support it , cameraX will check for immediate higher supported resolution or fallback to minimum supported resolution than 1920 x 1440
Checklist
To ensure this pull request meets the requirements for merging, please complete the checklist below:
This PR contains
Important Notes
Thank you for keeping our documentation up-to-date! 🚀
What should be covered while testing?
...
Extra comments (optional)
Please add extra comments or delete the section if not required