Repository navigation
[unplugin] Clear collected CSS when a module drops its StyleX import … - #2016
Open
jennymeshaiah09 wants to merge 1 commit into
Open
jennymeshaiah09 wants to merge 1 commit into
jennymeshaiah09 wants to merge 1 commit into
Conversation
…eta#2015) transform returned early when shouldHandle became false, skipping the metadata.stylex cleanup path. Removing the last style while keeping the import already cleared CSS; dropping the import left stale rules.
|
@cursoragent is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
Bot
added
the
CLA Signed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…(#2015)
transform returned early when shouldHandle became false, skipping the metadata.stylex cleanup path. Removing the last style while keeping the import already cleared CSS; dropping the import left stale rules.
What changed / motivation ?
After a successful transform, replacing a styled module with code that has no
StyleX import left its previous rules in the collected CSS. Removing the last
style while keeping the import already cleared CSS in the same sequence.
transformreturned immediately atif (!shouldHandle(code)) return null.Once the import is gone,
shouldHandleis false, so the existing cleanup inthe
metadata.stylexbranch never runs.On that early return, drop the module's entries from both stores, bump the
shared CSS version when entries existed, and call the existing disk-persistence
cleanup. The empty-metadata path uses the same helper.
Linked PR/Issues
Fixes # (issue)
#2015
Pre-flight checklist
Contribution Guidelines