Correct post-quantum algorithm classification and detection patterns - #659
Merged
Giulia Stocco (gfs) merged 2 commits intoSep 14, 2026
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: gfs <98900+gfs@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add detection for quantum computing and cryptography features
Correct post-quantum algorithm classification and detection patterns
Sep 10, 2026
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Giulia Stocco (gfs)
marked this pull request as ready for review
September 10, 2026 21:10
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The corrected patterns are valid, appropriately classified, and covered by default-rule self-tests.
Pull request overview
Corrects post-quantum cryptography rule classification and detection patterns.
Changes:
- Corrects Kyber, Dilithium, and stateless-signature classification.
- Supports FIPS name separator variants and fixes SPHINCS spelling.
- Adds positive and negative regression cases.
File summaries
| File | Description |
|---|---|
AppInspector/rules/default/cryptography/post_quantum.json |
Updates post-quantum patterns and inline regression tests. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Anthony Poole (Anthony50102)
approved these changes
Sep 14, 2026
Giulia Stocco (gfs)
deleted the
copilot/update-quantum-cryptography-rules
branch
September 14, 2026 22:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing post-quantum rules misclassify Kyber as ML-DSA, miss spaced FIPS names, and contain misspelled or unrelated algorithm terms.
CRYSTALS-Kyberdetection to ML-KEM.CRYSTALS-Dilithiumin ML-DSA and remove copied Kyber constants.hddand statefulxmssfrom the stateless signature rule; substitutinghsswould also misclassify a stateful scheme.sphincxtosphincs, matchingSPHINCS+.