Repository navigation
Fix ty truthiness-test-of-none-union failures in bcbench-core - #947
Merged
Merged
Conversation
Contributor
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 70c54f79-d7a0-4cde-baf2-e53dfff3deb4
Sun Haoran (haoranpb)
force-pushed
the
fix/pre-commit-ty-lock
branch
from
October 7, 2026 12:57
47a31fe to
084273d
Compare
Sun Haoran (haoranpb)
added this pull request to stack #957
October 7, 2026 12:57
Sun Haoran (haoranpb)
changed the title
Sun Haoran (haoranpb)
marked this pull request as ready for review
October 7, 2026 13:12
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted fixes preserve prior semantics and are adequately covered by focused tests.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes new ty truthiness diagnostics in bcbench-core while preserving existing behavior.
Changes:
- Uses explicit
bool(...)checks for optional collections and logging arguments. - Adds tests for
Noneand empty collections.
| File | Description |
|---|---|
packages/bcbench-core/src/bcbench_core/bc.py |
Makes function-name truthiness explicit. |
packages/bcbench-core/src/bcbench_core/logs.py |
Makes log argument truthiness explicit. |
packages/bcbench-core/tests/test_bc.py |
Tests absent and empty function lists. |
packages/bcbench-core/tests/test_logs.py |
Tests preservation of empty log arguments. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Wenjie Fan (gggdttt)
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Pre-commit started failing because
uv check --package bcbench-coreran a floating ty (0.0.85) instead of the locked 0.0.84, and 0.0.85 flagstruthiness-test-of-none-unionin bcbench-core.What
Python-only fixes for those failures in
bc.pyandlogs.py(plus tests). No pre-commit or workspace config changes; the root cause (unpinned ty) is addressed at the top of the stack in #956.Part of the stack that makes ty strict (
all = "error") across the whole uv workspace. Each PR fixes one rule in Python code only; the config change lands in #956.