Repository navigation
Add @override to methods flagged by ty missing-override-decorator - #950
Merged
Sun Haoran (haoranpb) merged 1 commit intoOct 8, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 70c54f79-d7a0-4cde-baf2-e53dfff3deb4
Sun Haoran (haoranpb)
added this pull request to stack #957
October 7, 2026 12:57
Contributor
Code Coverage OverviewLanguages: Python Python / code-coverage/pytestThe overall line coverage in commit c587b1f in the Show a line coverage summary of the most impacted files.
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The annotations target inherited members, use correct decorator ordering, and are supported by the required Python version.
Review effort: Balanced
Findings: None
What changed in this PR
Adds explicit override annotations across BC-Bench’s Python code, preparing for strict ty checks in #956 without changing evaluation logic.
Changes:
- Imports
typing.overrideand annotates inherited methods. - Covers dataset models, evaluation pipelines, results, and test helpers.
- Preserves correct decorator ordering for properties and class methods.
| File | Description |
|---|---|
| tests/test_mcp_gateway.py | Annotates HTTP handler overrides. |
| tests/test_evaluate_pipeline.py | Annotates test pipeline overrides. |
| src/bcbench/results/testgeneration.py | Annotates test-generation result overrides. |
| src/bcbench/results/summary.py | Annotates summary overrides. |
| src/bcbench/results/leaderboard.py | Annotates aggregation overrides. |
| src/bcbench/results/codereview.py | Annotates review result and summary overrides. |
| src/bcbench/results/base.py | Annotates specialized result overrides. |
| src/bcbench/evaluate/testgeneration.py | Annotates test-generation pipeline overrides. |
| src/bcbench/evaluate/nl2al.py | Annotates NL2AL pipeline overrides. |
| src/bcbench/evaluate/ext_request_triage.py | Annotates triage pipeline overrides. |
| src/bcbench/evaluate/ext_request_implement.py | Annotates implementation pipeline overrides. |
| src/bcbench/evaluate/ext_request_advisor.py | Annotates advisor pipeline overrides. |
| src/bcbench/evaluate/dataquery.py | Annotates data-query pipeline overrides. |
| src/bcbench/evaluate/codereview.py | Annotates code-review pipeline overrides. |
| src/bcbench/evaluate/bugfix.py | Annotates bug-fix pipeline overrides. |
| src/bcbench/dataset/extensibility_request.py | Annotates extensibility entry overrides. |
| src/bcbench/dataset/dataset_entry.py | Annotates dataset entry overrides. |
| src/bcbench/dataset/codereview.py | Annotates review entry and string overrides. |
| src/bcbench/commands/evaluate.py | Annotates mock pipeline overrides. |
| src/bcbench/agent/shared/mcp_gateway.py | Annotates proxy logging override. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Wenjie Fan (gggdttt)
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
@overrideto every method flagged by tymissing-override-decorator. Python only.Part of the stack that makes ty strict (
all = "error") across the whole uv workspace. Each PR fixes one rule in Python code only; the config change lands in #956.