Repository navigation
Add type arguments flagged by ty missing-type-argument - #951
Merged
Sun Haoran (haoranpb) merged 1 commit intoOct 8, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 70c54f79-d7a0-4cde-baf2-e53dfff3deb4
Sun Haoran (haoranpb)
added this pull request to stack #957
October 7, 2026 12:57
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Contributor
Code Coverage OverviewLanguages: Python Python / code-coverage/pytestThe overall line coverage in commit 31b1d1a in the Show a line coverage summary of the most impacted files.
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes consistently complete generic annotations while preserving existing runtime behavior and type relationships.
Review effort: Balanced
Findings: None
What changed in this PR
Adds explicit generic type arguments throughout Python code to satisfy ty’s missing-type-argument rule without changing runtime behavior.
Changes:
- Types dictionaries, lists, subprocess results, evaluation contexts, pipelines, and runners.
- Adds required
Anyand dataset-entry imports. - Aligns DataQuery’s runner signature with the shared protocol.
| File | Description |
|---|---|
tools/probe_codereview_case.py |
Types probe data and subprocess results. |
tools/ood_worklist.py |
Types loaded entries and findings. |
tools/fix_enrichment_iteration_2.py |
Types enrichment entries. |
tools/fix_enrichment_iteration_1.py |
Types fix callbacks and entries. |
tools/dump_entries.py |
Types OOD findings. |
tools/apply_enrichment.py |
Types enrichment designs. |
tests/test_pr_review_output.py |
Types report fixtures. |
tests/test_pr_review_agent.py |
Types malformed-report parameters. |
tests/test_mcp_config.py |
Types MCP configuration helpers. |
tests/test_lsp_config.py |
Types parsed LSP configuration. |
tests/test_dataquery_evaluation.py |
Specifies the DataQuery context type. |
tests/test_claude_code_metrics.py |
Types stream events. |
tests/test_agent_plugins.py |
Types plugin configuration helpers. |
src/bcbench/types.py |
Types category pipelines. |
src/bcbench/results/testgeneration.py |
Types result factory contexts. |
src/bcbench/results/codereview.py |
Types code-review result contexts. |
src/bcbench/results/bugfix.py |
Types bug-fix result contexts. |
src/bcbench/results/base.py |
Types shared result factory contexts. |
src/bcbench/operations/skills_operations.py |
Types skill configuration. |
src/bcbench/operations/instruction_operations.py |
Types instruction and agent configuration. |
src/bcbench/operations/dataquery_operations.py |
Types query result rows. |
src/bcbench/evaluate/dataquery.py |
Types the DataQuery agent runner. |
src/bcbench/agent/shared/prompt.py |
Types prompt configuration. |
src/bcbench/agent/shared/plugin.py |
Types plugin configuration. |
src/bcbench/agent/shared/mcp_gateway.py |
Types JSON-RPC payloads and responses. |
src/bcbench/agent/shared/lsp.py |
Types generated LSP configuration. |
src/bcbench/agent/copilot/metrics.py |
Types Copilot tool records. |
src/bcbench/agent/claude/metrics.py |
Types Claude tool records. |
evaluator/scores.py |
Types scorer metadata. |
evaluator/metrics.py |
Types metrics metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Wenjie Fan (gggdttt)
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add explicit type arguments flagged by ty
missing-type-argument(mostly baredict->dict[str, Any], plus generic classes such asAgentRunner,EvaluationContext,CompletedProcess). Python only.Part of the stack that makes ty strict (
all = "error") across the whole uv workspace. Each PR fixes one rule in Python code only; the config change lands in #956.