Skip to content

feat: Add new event - #11625

Open
F!do (fridrichovsky) wants to merge 2 commits into
microsoft:mainfrom
fridrichovsky:feature/11020
Open

F!do (fridrichovsky) wants to merge 2 commits into
microsoft:mainfrom
fridrichovsky:feature/11020

Conversation

@fridrichovsky

@fridrichovsky F!do (fridrichovsky) commented Sep 18, 2026

Copy link
Copy Markdown

What & why

Our module works with web orders and this require skip confirmations during Sales Advance Header create. We ask for option how to skip confirmations during this process for automatic tasks.

Linked work

Fixes #11020

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome (required ΓÇö be specific: scenarios, commands, screenshots for UI changes)

Added new event integration no new test required.

Risk & compatibility

Fixes AB#650549

@fridrichovsky
F!do (fridrichovsky) requested a review from a team as a code owner September 18, 2026 14:20
@github-actions github-actions Bot added From Fork Pull request is coming from a fork Team: Finance GitHub request for Finance area ADO: Sync Creates an Azure DevOps work item if needed and indicates that one is linked labels Sep 18, 2026
@github-actions github-actions Bot added this to the Version 30.0 milestone Sep 18, 2026
@github-actions github-actions Bot added needs-approval Workflow runs require maintainer approval to start and removed needs-approval Workflow runs require maintainer approval to start labels Sep 18, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept with Suggestions

What this PR does

This change adds an integration event after a sales advance letter is created and before the report asks whether to open the new letter. A subscriber can set IsHandled to skip both the confirmation and the page open, which matches the reported need for automated creation. The event is in the right place for that goal, and it does not change the default behavior when no subscriber handles it.

Problem-solution fit

Fit: Strong

The reported scenario needs a way to suppress the final confirmation and page opening after the document is created. The diff adds a narrow extension point around exactly that UI step without changing the creation logic.

Suggestions

S1 (🟠 Moderate): Fix the event name spelling
The new event name says Confitm instead of Confirm. Please fix this before merge, because an integration event name becomes a public contract after release.

Risk assessment and necessity

Risk: The runtime risk is low because existing behavior stays the same unless a subscriber handles the new event. The main risk is compatibility: the new integration event name will be hard to rename after it ships.

Necessity: The change is needed to support automated sales advance letter creation without a blocking UI prompt. The scope is small and appropriate for an extensibility request, and no test is required for this event-only surface.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11625 round=1 by=alexei-dobriansky at=2026-09-18T19:09:27Z lastSha=9c904d3bd9893c6ccf948a1503dc4befd522b4b6 reviewKey=46cc083f13ed96c679c89daa95dcc09b82a0a141f3744fc04ccfbc6c06259174 suggestions=S1@d8f48e06

@github-actions github-actions Bot added the needs-approval Workflow runs require maintainer approval to start label Sep 18, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 2

Recommendation: Accept

What this PR does

The new commit corrects the public integration event name from OnPostReportOnBeforeConfitmOpenAdvanceLetter to OnPostReportOnBeforeConfirmOpenAdvanceLetter. The event remains before the existing confirmation and page-open step, and the default behavior is unchanged when no subscriber sets IsHandled.

Status of previous suggestions
ID Title Status Author response
S1 Fix the event name spelling Addressed Fixed in 01230de
New observations (commits since round 1)

None - changes only addressed the prior suggestion.

Risk assessment and necessity

Risk: Low. This remains an additive event-only change, and the corrected name removes the public-contract risk identified in round 1.

Necessity: The event supports automated sales advance letter creation that must avoid the final confirmation and page open. The scope remains narrow and appropriate for an extensibility request.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11625 round=2 by=alexei-dobriansky at=2026-09-19T07:07:06.7807657Z lastSha=01230de02f6e03b90df7e701d7f5f284c9f21b6d reviewKey=2203cd890df251ef41a2d3ab7b8065dda078446867d60a92156a8d0ca542d604 suggestions=S1@d8f48e06:addressed parentRound=1

@github-actions github-actions Bot added needs-approval Workflow runs require maintainer approval to start and removed needs-approval Workflow runs require maintainer approval to start labels Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ADO: Sync Creates an Azure DevOps work item if needed and indicates that one is linked From Fork Pull request is coming from a fork needs-approval Workflow runs require maintainer approval to start Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Event Request] Report 31012 "Create Sales Adv. Letter CZZ".OnPostReport

2 participants