feat: Add new event - #11625
feat: Add new event#11625F!do (fridrichovsky) wants to merge 2 commits into
Conversation
Good Sense Reviewer - Round 1Recommendation: Accept with SuggestionsWhat this PR doesThis change adds an integration event after a sales advance letter is created and before the report asks whether to open the new letter. A subscriber can set Problem-solution fitFit: Strong The reported scenario needs a way to suppress the final confirmation and page opening after the document is created. The diff adds a narrow extension point around exactly that UI step without changing the creation logic. SuggestionsS1 (🟠 Moderate): Fix the event name spelling Risk assessment and necessityRisk: The runtime risk is low because existing behavior stays the same unless a subscriber handles the new event. The main risk is compatibility: the new integration event name will be hard to rename after it ships. Necessity: The change is needed to support automated sales advance letter creation without a blocking UI prompt. The scope is small and appropriate for an extensibility request, and no test is required for this event-only surface.
|
Good Sense Reviewer - Round 2Recommendation: AcceptWhat this PR doesThe new commit corrects the public integration event name from Status of previous suggestions
New observations (commits since round 1)None - changes only addressed the prior suggestion. Risk assessment and necessityRisk: Low. This remains an additive event-only change, and the corrected name removes the public-contract risk identified in round 1. Necessity: The event supports automated sales advance letter creation that must avoid the final confirmation and page open. The scope remains narrow and appropriate for an extensibility request.
|
What & why
Our module works with web orders and this require skip confirmations during Sales Advance Header create. We ask for option how to skip confirmations during this process for automatic tasks.
Linked work
Fixes #11020
How I validated this
What I tested and the outcome (required ΓÇö be specific: scenarios, commands, screenshots for UI changes)
Added new event integration no new test required.
Risk & compatibility
Fixes AB#650549