Expense Agent: capture submission policy evaluation history - #11628
Draft
Prangshuman Das (t-prda) wants to merge 5 commits into
Draft
Prangshuman Das (t-prda) wants to merge 5 commits into
Prangshuman Das (t-prda) wants to merge 5 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d9178a5c-c5ff-43a4-b9cb-877ec18618fa
Remove callback APIs, capability and separate policy history codeunit. Reuse existing activity writer with per-submission deduplication. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d9178a5c-c5ff-43a4-b9cb-877ec18618fa
Use distinct category names with shared JSON ellipsis handling and consolidate policy history regression tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d9178a5c-c5ff-43a4-b9cb-877ec18618fa
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d9178a5c-c5ff-43a4-b9cb-877ec18618fa
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d9178a5c-c5ff-43a4-b9cb-877ec18618fa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Capture at most one report-level
PolicyEvaluatedhistory snapshot for each submission/resubmission using two existing BC execution paths."..."entry on overflow while continuing to count all policy checks.MarkPoliciesEvaluatedline confirmation, use the same helper to check the whole pending-approval report and log when ready.Expense Activity Log Mgt.with header-first report-scoped locking.Simplification
Removed the separate
Expense Policy Historycodeunit, new submit/completion API actions, capability, correlation fields, context hashes, and header-invalidation subscribers. No service callback is required. Only the existing read-only activity API gains snapshot fields.Tracking
Closes #11627
Related planning: AB#634361 and AB#626515 (neither slice is closed by this PR).
Companion service issue: https://microsoft.ghe.com/bic/BC-ExpenseAgent/issues/2754
Companion draft PR: https://microsoft.ghe.com/bic/BC-ExpenseAgent/pull/2755
Validation and review
git diff --check.Draft for code review. No dispatch or AL execution was performed.
The initial implementation targets
main; the planned 29.0 backport is not included.