Skip to content

[29.x] [ALL-E] Sales Line Discount % accepts 5 decimal places through Configuration Package import but rejects manual entry beyond 2 decimal places. - #11634

Open
Shikhverma wants to merge 1 commit into
releases/29.xfrom
bugs/Bug-650373--29.x]ConfigPackImportButRejectManualEntryBeyond2Decimalplace
Open

Shikhverma wants to merge 1 commit into
releases/29.xfrom
bugs/Bug-650373--29.x]ConfigPackImportButRejectManualEntryBeyond2Decimalplace

Conversation

@Shikhverma

@Shikhverma Shikhverma commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Bug 650373: [29.x][ALL-E] Sales Line Discount % accepts 5 decimal places through Configuration Package import but rejects manual entry beyond 2 decimal places.

Fixes AB#650373

@github-actions github-actions Bot added the Team: SCM GitHub request for SCM area label Sep 21, 2026
@github-actions github-actions Bot added this to the Version 29.1 milestone Sep 21, 2026
@Shikhverma
Shikhverma marked this pull request as ready for review September 21, 2026 08:10
@Shikhverma
Shikhverma requested review from a team as code owners September 21, 2026 08:10
@Shikhverma
Shikhverma enabled auto-merge (squash) September 21, 2026 08:10
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This PR lets the legacy Sales Line Discount % field accept up to 5 decimal places in manual entry, matching values that can already be stored through import and matching related pricing tables. The table-level DecimalPlaces = 0 : 5 change is narrow, the page uses the table field directly, and the added page-entry tests exercise the reported manual-entry path across the affected test apps.

Problem-solution fit

Fit: Strong

The reported problem is an inconsistency between stored/imported precision and manual UI validation. The change fixes that exact validation surface without changing discount calculation logic or widening the value range beyond the existing 0-100 bounds.

Suggestions

None.

Risk assessment and necessity

Risk: The touched field is part of sales discount setup, so incorrect precision handling could affect pricing input. The implementation is low risk because it only changes the field precision accepted by validation, keeps the existing minimum and maximum values, and aligns sales with analogous purchase and price-list fields that already allow 5 decimals.

Necessity: The change is needed so users can manually maintain discount values that the system can already store through import. Without it, records with valid 5-decimal discounts remain difficult to edit through the UI and the behavior stays inconsistent between entry methods.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11634 round=1 by=alexei-dobriansky at=2026-09-21T12:04:38Z lastSha=2e307bab99f31041c3d49279f2a54047827ececb reviewKey=2748632ef596d70f40388bcf29d206dc9793b9a31bba05d1543db259b49bdcad suggestions=none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants