Skip to content

[Master]-[Financial Reports] Page cannot open because of FlowField 'Last Run By User' - #11640

Open
Fixes4BC (neeleshsinghal) wants to merge 1 commit into
mainfrom
bugs/Bug-649982-Financial-Reports-Page-cannot-open-because-Last-Run-By-User
Open

Fixes4BC (neeleshsinghal) wants to merge 1 commit into
mainfrom
bugs/Bug-649982-Financial-Reports-Page-cannot-open-because-Last-Run-By-User

Conversation

@neeleshsinghal

@neeleshsinghal Fixes4BC (neeleshsinghal) commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Fixes AB#649982

@neeleshsinghal
Fixes4BC (neeleshsinghal) requested a review from a team as a code owner September 21, 2026 08:17
@github-actions github-actions Bot added the Team: Finance GitHub request for Finance area label Sep 21, 2026
@github-actions github-actions Bot added this to the Version 30.0 milestone Sep 21, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Request Changes

What this PR does

This change updates the Last Run by User FlowField on the Financial Report table so the page no longer depends on the current-user filter token. The change is very small, but it replaces the dynamic current-user filter with a literal value, so it does not preserve the behavior the field name and surrounding page logic require.

Problem-solution fit

Fit: Partial

The bug is valid and the change targets the failing FlowField, but the implementation only avoids the failure by no longer filtering to the signed-in user. The result can be blank or wrong for normal users.

Suggestions

S1 (🔴 High): Keep filtering by the current user
The new filter uses the literal value user, so Your Last Run will only find audit rows for a user actually named user. Keep the exact current-user behavior, for example by using a FlowFilter set with UserId() or another exact filter path that does not re-parse special characters.

Risk assessment and necessity

Risk: The regression surface is narrow to Financial Reports pages and the last-run value. There is no posting or ledger impact, but every user can see a blank or incorrect last-run timestamp.

Necessity: A fix is needed because the page can fail to open when the current user value contains filter-special characters. The scope is right, but the fix still needs to preserve per-user filtering.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11640 round=1 by=alexei-dobriansky at=2026-09-21T20:12:42.6553840Z lastSha=7a036eeeb98d39f83a29b1d103c413a306bd0dce reviewKey=71c154a200f56137e6fe0d9215b2a77a50fcc9ce4f6935884956c4fcebe2048f suggestions=S1@8cbcb62c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants