Skip to content

Align Expense setup obsoletion with release 29 - #11643

Draft
Prangshuman Das (t-prda) wants to merge 1 commit into
mainfrom
t-prda-expense-setup-baseline-alignment
Draft

Prangshuman Das (t-prda) wants to merge 1 commit into
mainfrom
t-prda-expense-setup-baseline-alignment

Conversation

@t-prda

@t-prda Prangshuman Das (t-prda) commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

What & why

Align the Expense Agent setup-page obsoletion boundaries on main with the first release that contains them. Original #11541 introduced these boundaries as CLEAN30 / 30.0; merged backports #11613 (releases/29.x) and #11614 (releases/29.0) introduced the same obsoletions in release 29.

This changes only src/Apps/W1/ExpenseAgent/app/src/Setup/Pages/ExpenseAgentSetup.Page.al: exactly seven CLEAN30 guards become CLEAN29, and exactly 20 ObsoleteTag = '30.0' values become 29.0. The affected hidden controls/groups cover agent activation, receipt submission, outgoing communication and reminders, policy evaluation, projects, and shortest routes, plus their guarded helper/label. Existing release-29 obsoletions are untouched.

Prepared from fresh main commit 00e995d263ccd6eb50cf85d5a28d5704a1b89e66, not an old feature branch. Keep this PR draft until the compatibility baseline contains the merged release-29 obsoletions and CI verifies the alignment. Baseline synchronization may take several days; this PR does not assert that it has happened.

Linked work

AB#640269 — informational link to the original, already-resolved source work; this PR does not reopen or resolve it again.

Original merged PR: #11541 (9f382f608fab7e117cfeb1e33fa9f70259386bfa).

Merged release backports: #11613 (a66254c3b8b5bb1cea290dc8f9d097aec4381153) and #11614 (655a715dc7a7960d7e8a1f96d434d4abc1fc1d8f).

No new GitHub issue is linked: this is the follow-up alignment of the existing Microsoft work item and merged PRs above.

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome

  • Compared the original squash commit, both merged backports, and fresh main. Main's setup page was unchanged since Clarify Expense Agent and expense management setup #11541; both backports have the same setup-page content.
  • Line-by-line validation confirmed exactly seven guard substitutions and 20 tag substitutions, with no other content changes. The resulting page matches the merged release references. Git reports one file, 27 insertions and 27 deletions; git diff --check passed.
  • No local AL build, tests, publish, or runtime/environment changes were performed, as explicitly requested by the change owner. Validation is CI-only; CI is pending, not claimed passed.
  • No tests were added: this adjusts only obsoletion metadata and cleanup boundaries. Default-path statements, page layout properties, and behavior are preserved; existing tests are unchanged.

Risk & compatibility

The cleanup boundary intentionally moves earlier to release 29, matching when the public controls/groups were first made Pending by the merged backports. Normal builds with cleanup symbols unset retain the same controls and statements; builds defining CLEAN29 now exclude these obsolete controls and their helper/label.

At preparation time, build/Packages.json pins AppBaselines-BCArtifacts to 29.1.54166.0. That package's presence alone does not prove that it includes the backports. Keep draft pending compatibility-baseline verification and successful required CI checks. No baseline files, diagnostics, manifests/versions, schemas, object IDs, tests, or unrelated behavior were changed. This does not include any email-lifecycle changes from #11615, and does not enable automatic merge or mark the PR ready.

Align the seven cleanup guards and twenty obsoletion tags introduced by #11541 with merged release backports #11613 and #11614. Related to AB#640269.

Copilot-Session: 7a535d01-fbef-4fb8-b5e9-ad0c29f2921c

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area labels Sep 21, 2026
@github-actions github-actions Bot added this to the Version 30.0 milestone Sep 21, 2026

This branch was successfully deployed

1 active deployment
triage be42a331 Deployed Sep 21, 2026 by t-prda via Classify team ownership #5258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant