[main] Allocation Accounts with Invoice Discount produces wrong posted entries in Sales and Purchases documents in the Spanish version. - #11645
Draft
Shikhverma wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: AB#650386
Issue:
When posting Sales/Purchase documents using Allocation Accounts in the Spanish (ES) version, invoice discount was being applied twice, producing incorrect posted entries.
Root Cause:
The allocation logic used the Amount field to derive AmountToAllocate. On ES documents, Amount already reflects the invoice discount applied at the line level. Passing this discounted value into the allocation calculation caused the discount percentage to be applied a second time during allocation, understating the allocated/posted amounts.
Solution:
Changed the source field for AmountToAllocate from Amount to Line Amount (the pre-discount value), so invoice discount is applied exactly once. Allocation Accounts now produce correct posted entries in Sales and Purchase documents.