Skip to content

Fix Workday discovery and workbook guidance - #471

Merged
Surendra Goutham (is-goutham) merged 2 commits into
mainfrom
fix/workday-discovery-version-and-workbook-guidance
Oct 28, 2026
Merged

Surendra Goutham (is-goutham) merged 2 commits into
mainfrom
fix/workday-discovery-version-and-workbook-guidance

Conversation

@is-goutham

Copy link
Copy Markdown
Contributor

Description

Preserve the configured API version during Workday connection discovery and clarify API-client setup before administrators capture workbook values.

Related issue

Refs #461

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor / cleanup

Testing

210 focused tests passed. Coverage includes prerequisites, connection verification, Runtime preview/apply, and workbook guidance.

Commands and results
  • python -m pytest tests\scripts\test_workday_connect_runtime.py tests\scripts\test_workday_connect_prerequisites.py tests\scripts\test_workday_connect_contracts.py -q --tb=short --no-showlocals - 210 passed.
  • python -m ruff check solutions\ess-maker-skills\scripts\workday_connect.py solutions\ess-maker-skills\scripts\workday_connect_runtime.py solutions\ess-maker-skills\scripts\workday_connect_prerequisites.py solutions\ess-maker-skills\scripts\workday_connect_workday_admin_contracts.py tests\scripts\test_workday_connect_runtime.py tests\scripts\test_workday_connect_prerequisites.py tests\scripts\test_workday_connect_contracts.py - passed.
  • git diff --check - passed.
  • python -m pytest tests\setup\test_connect_lifecycle.py tests\setup\test_workday_da_orchestration.py tests\scripts\test_workday_connect_preflight.py tests\scripts\test_workday_connect_flightcheck.py -q --tb=short --no-showlocals - 131 passed, 1 failed. The pre-existing test_workday_topic_activation_uses_complete_mapped_scope assertion expects the literal phrase "all 23" in the topic-enabling guide. Both that test and its input guide are unchanged from main; this unrelated failure is not modified here.

Checklist

  • My code follows the existing style
  • I have added/updated tests where applicable
  • I have updated documentation as needed

Static validation (samples/ only)

Validation
- YAML parse: N-A
- AdaptiveDialog kind: N-A
- XML parse: N-A
- Filename convention (new): N-A
- Folder convention (new, incl. README.md): N-A
- Diff scope (samples/ only): N-A
- Secrets / internal URLs: N-A

Copilot-Session: 8534f8ab-983a-4aea-8732-3ebce2dde3c1

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the API-version propagation and API-client setup guidance changes.

No open issues 🎉

What changed in this PR

This PR improves Workday Connect discovery by preserving the foundation’s configured API version across prerequisite checks, connection verification, and Runtime preview/apply. It also clarifies API-client setup before administrators capture workbook values, continuing the setup and recovery improvements in #461.

Changes:

  • Pass the optional agentBuilderApiVersion through connection discovery, retaining the native default when absent.
  • Clarify that administrators must reuse or register an API client before recording its ID and endpoints.
  • Add regression coverage for API-version propagation, configuration validation, and workbook guidance.
File Description
tests/​scripts/​test_workday_connect_runtime.py Tests API-version propagation, invalid configuration, and unchanged saved state.
tests/​scripts/​test_workday_connect_prerequisites.py Tests configured and default API versions during prerequisite discovery.
tests/​scripts/​test_workday_connect_contracts.py Checks workbook and packet guidance for client setup before value capture.
solutions/​ess-maker-skills/​src/​skills/​connect/​workday/​shared/​config-schema.md Documents discovery API-version behavior and state preservation.
solutions/​ess-maker-skills/​scripts/​workday_connect.py Passes the configured version into connection verification and Runtime operations.
solutions/​ess-maker-skills/​scripts/​workday_connect_workday_admin_contracts.py Clarifies client reuse or registration before capturing OAuth details.
solutions/​ess-maker-skills/​scripts/​workday_connect_runtime.py Reads and validates the configured version and propagates it to discovery.
solutions/​ess-maker-skills/​scripts/​workday_connect_prerequisites.py Uses the configured version for prerequisite connection checks.

Review effort: Balanced

@daeunJe0ng Dawn Jeong (daeunJe0ng) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static review at e6789d7: no actionable defects found. Tests and live behavior were not independently verified.

@is-goutham
Surendra Goutham (is-goutham) merged commit fc15429 into main Oct 28, 2026
9 checks passed
@daeunJe0ng
Dawn Jeong (daeunJe0ng) deleted the fix/workday-discovery-version-and-workbook-guidance branch October 29, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants