Repository navigation
Fix Workday discovery and workbook guidance - #471
Merged
Surendra Goutham (is-goutham) merged 2 commits intoOct 28, 2026
Merged
Surendra Goutham (is-goutham) merged 2 commits into
Surendra Goutham (is-goutham) merged 2 commits into
Conversation
Copilot-Session: 8534f8ab-983a-4aea-8732-3ebce2dde3c1
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the API-version propagation and API-client setup guidance changes.
No open issues 🎉
What changed in this PR
This PR improves Workday Connect discovery by preserving the foundation’s configured API version across prerequisite checks, connection verification, and Runtime preview/apply. It also clarifies API-client setup before administrators capture workbook values, continuing the setup and recovery improvements in #461.
Changes:
- Pass the optional
agentBuilderApiVersionthrough connection discovery, retaining the native default when absent. - Clarify that administrators must reuse or register an API client before recording its ID and endpoints.
- Add regression coverage for API-version propagation, configuration validation, and workbook guidance.
| File | Description |
|---|---|
tests/scripts/test_workday_connect_runtime.py |
Tests API-version propagation, invalid configuration, and unchanged saved state. |
tests/scripts/test_workday_connect_prerequisites.py |
Tests configured and default API versions during prerequisite discovery. |
tests/scripts/test_workday_connect_contracts.py |
Checks workbook and packet guidance for client setup before value capture. |
solutions/ess-maker-skills/src/skills/connect/workday/shared/config-schema.md |
Documents discovery API-version behavior and state preservation. |
solutions/ess-maker-skills/scripts/workday_connect.py |
Passes the configured version into connection verification and Runtime operations. |
solutions/ess-maker-skills/scripts/workday_connect_workday_admin_contracts.py |
Clarifies client reuse or registration before capturing OAuth details. |
solutions/ess-maker-skills/scripts/workday_connect_runtime.py |
Reads and validates the configured version and propagates it to discovery. |
solutions/ess-maker-skills/scripts/workday_connect_prerequisites.py |
Uses the configured version for prerequisite connection checks. |
Review effort: Balanced
Dawn Jeong (daeunJe0ng)
approved these changes
Oct 28, 2026
Dawn Jeong (daeunJe0ng)
left a comment
Contributor
There was a problem hiding this comment.
Static review at e6789d7: no actionable defects found. Tests and live behavior were not independently verified.
Dawn Jeong (daeunJe0ng)
deleted the
fix/workday-discovery-version-and-workbook-guidance
branch
October 29, 2026 16:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve the configured API version during Workday connection discovery and clarify API-client setup before administrators capture workbook values.
Related issue
Refs #461
Type of change
Testing
210 focused tests passed. Coverage includes prerequisites, connection verification, Runtime preview/apply, and workbook guidance.
Commands and results
python -m pytest tests\scripts\test_workday_connect_runtime.py tests\scripts\test_workday_connect_prerequisites.py tests\scripts\test_workday_connect_contracts.py -q --tb=short --no-showlocals- 210 passed.python -m ruff check solutions\ess-maker-skills\scripts\workday_connect.py solutions\ess-maker-skills\scripts\workday_connect_runtime.py solutions\ess-maker-skills\scripts\workday_connect_prerequisites.py solutions\ess-maker-skills\scripts\workday_connect_workday_admin_contracts.py tests\scripts\test_workday_connect_runtime.py tests\scripts\test_workday_connect_prerequisites.py tests\scripts\test_workday_connect_contracts.py- passed.git diff --check- passed.python -m pytest tests\setup\test_connect_lifecycle.py tests\setup\test_workday_da_orchestration.py tests\scripts\test_workday_connect_preflight.py tests\scripts\test_workday_connect_flightcheck.py -q --tb=short --no-showlocals- 131 passed, 1 failed. The pre-existingtest_workday_topic_activation_uses_complete_mapped_scopeassertion expects the literal phrase "all 23" in the topic-enabling guide. Both that test and its input guide are unchanged frommain; this unrelated failure is not modified here.Checklist
Static validation (samples/ only)