fix(tree): forking during changed event (2.116 backport) - #28074
Conversation
## Description [Forking](https://fluidframework.com/docs/api/fluid-framework/treeviewbeta-interface#fork-methodsignature) (beta) a view during the callback for the ["changed" event](https://fluidframework.com/docs/api/fluid-framework/treebranchevents-interface#changed-methodsignature) (alpha) emitted when a transaction is committed would create a fork with malformed change data. This could result in asserts being triggered when utilizing the fork (including, but not limited to, error code `0x7ce`). This PR also changes usages of `activeBranch` to `branch` wherever appropriate in `treeCheckout.ts`. I have added a PR comment explaining my reasoning for each change. ## Breaking Changes None
|
Warning WARNING: This PR is targeting a release branch! All changes must first be merged into Changes to release branches require approval from the Patch Triage group before merging. For more details, see our internal documentation for the patch policy and processes for |
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (40 lines, 3 files), I've queued these reviewers:
How this works
|
Bundle size comparisonBase commit: Notable changesNo bundles changed by ≥ 500 bytes parsed. Per-bundle deltas
|
ca9458a
into
microsoft:release/client/2.116
Description
Cherry-picks commit
53eb97dcb06a9563caf37275f89f20b28104461dfrom PR #28008 intorelease/client/2.116.This fixes malformed change data when a tree view is forked during the
changedevent emitted after a transaction commits. The malformed fork could trigger assertions when it was later used.Reviewer Guidance
The review process is outlined in the pull request guidelines.
Please verify that this is an exact cherry-pick of the source commit.