Initial failWithTelemetry impl - #28075
Draft
Craig Macomber (Microsoft) (CraigMacomber) wants to merge 1 commit into
Draft
Initial failWithTelemetry impl#28075Craig Macomber (Microsoft) (CraigMacomber) wants to merge 1 commit into
Craig Macomber (Microsoft) (CraigMacomber) wants to merge 1 commit into
Conversation
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (206 lines, 9 files), I've queued these reviewers:
How this works
|
Contributor
Bundle size comparisonBase commit: unresolved The PR's CI build failed — fix the build and the comment will update once the next run succeeds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposed API, but we should prabably better integrate asserts with telemetry than implement it like this.
Reviewer Guidance
The review process is outlined in the pull request guidelines.