Repository navigation
Add missing type annotations. - #8644
Merged
Jens Hedegaard Nielsen (jenshnielsen) merged 20 commits intoOct 22, 2026
Merged
Jens Hedegaard Nielsen (jenshnielsen) merged 20 commits into
Jens Hedegaard Nielsen (jenshnielsen) merged 20 commits into
Conversation
Jens Hedegaard Nielsen (jenshnielsen)
requested a review
from a team
as a code owner
October 21, 2026 06:44
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8644 +/- ##
==========================================
- Coverage 72.62% 72.59% -0.03%
==========================================
Files 307 307
Lines 32431 32431
==========================================
- Hits 23552 23543 -9
- Misses 8879 8888 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…gument Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Annotate dataset test fixtures, helpers, and test signatures while preserving intentional dynamic typing boundaries and constructor return annotations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
None of the overloads gave only_names/only_types a None default, so calling with no arguments or with only one of them as a keyword matched no overload.
The plot button test received the plt.show mock as its tab fixture and neither test asserted anything, while the widget callback swallows all exceptions. Assert on the created tab, the plt.show call and the exported file, and export into tmp_path rather than the cwd.
The datasets were never prepared and results were keyed by name rather than ParamSpecBase, so no data was ever added and the tests only round-tripped empty datasets. Also assert that the data survives the round trip.
acquire only uses AcquisitionInterface methods but required an AcquisitionController. AcquisitionController also subclassed AcquisitionInterface[Any], so its type parameter never reached the return type of acquire.
With the minimum supported typing_extensions, Parameter[int] fails at runtime since TypeVar defaults are not applied, which broke test collection.
Jens Hedegaard Nielsen (jenshnielsen)
force-pushed
the
fix_deprecated_test_keithley
branch
from
October 21, 2026 20:40
ab371a3 to
46cf260
Compare
Older versions do not apply TypeVar defaults, so Parameter[int] fails at runtime on Python 3.12.
Cina Arjmand (CinaArjmand)
approved these changes
Oct 22, 2026
Jens Hedegaard Nielsen (jenshnielsen)
removed this pull request from the merge queue due to a manual request
Oct 22, 2026
Cina Arjmand (CinaArjmand)
approved these changes
Oct 22, 2026
Jens Hedegaard Nielsen (jenshnielsen)
deleted the
fix_deprecated_test_keithley
branch
October 22, 2026 13:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a bunch of missing type annotations and fix a few bugs in the related code