Repository navigation
Harden Galil DMC-41x3 motion polling and connection handling - #8647
Wouter Steman (WouterSteman) wants to merge 6 commits into
Conversation
Wouter Steman (WouterSteman)
commented
Oct 21, 2026
- Added time-based retries for parsing motion flags and position replies.
- Improved connection handling with multiple address candidates.
- Refactored wait methods for better clarity and functionality.
- Added time-based retries for parsing motion flags and position replies. - Improved connection handling with multiple address candidates. - Refactored wait methods for better clarity and functionality.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8647 +/- ##
==========================================
- Coverage 72.62% 72.45% -0.17%
==========================================
Files 307 307
Lines 32431 32495 +64
==========================================
- Hits 23552 23545 -7
- Misses 8879 8950 +71 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@microsoft-github-policy-service agree company="Microsoft" |
There was a problem hiding this comment.
🟡 Changes recommended
Malformed replies can still produce incorrect positions or bypass retries, and blocking controller reads can prevent timeout enforcement.
3 open issues
What changed in this PR
Hardens the Galil DMC-41x3 driver’s connection handling and motion polling.
Changes:
- Adds reply parsing with retries for motion flags and positions.
- Tries fallback connection address formats.
- Centralizes axis-specific motion waiting with a configurable timeout.
| File | Description |
|---|---|
| src/qcodes/instrument_drivers/Galil/dmc_41x3.py | Adds parsing helpers, connection fallbacks, and shared motion waits. |
| docs/changes/newsfragments/8647.improved_driver | Documents retries, timeouts, connection fallbacks, and interrupt handling. |
Review effort: Balanced
|
One or more custom setup steps configured for this repository failed during this Copilot code review run: Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review. Note You can configure setup steps for Copilot code review separately from Copilot cloud agent with a |
…uterSteman/Qcodes into galil_improvements_cryoprober

