Skip to content

Harden Galil DMC-41x3 motion polling and connection handling - #8647

Open
Wouter Steman (WouterSteman) wants to merge 6 commits into
microsoft:mainfrom
WouterSteman:galil_improvements_cryoprober
Open

Wouter Steman (WouterSteman) wants to merge 6 commits into
microsoft:mainfrom
WouterSteman:galil_improvements_cryoprober

Conversation

@WouterSteman

Copy link
Copy Markdown
  • Added time-based retries for parsing motion flags and position replies.
  • Improved connection handling with multiple address candidates.
  • Refactored wait methods for better clarity and functionality.

V-wsteman and others added 2 commits October 19, 2026 14:33
- Added time-based retries for parsing motion flags and position replies.
- Improved connection handling with multiple address candidates.
- Refactored wait methods for better clarity and functionality.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 2.40964% with 81 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.45%. Comparing base (ca6f357) to head (569a9c5).
⚠️ Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
src/qcodes/instrument_drivers/Galil/dmc_41x3.py 2.40% 81 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8647      +/-   ##
==========================================
- Coverage   72.62%   72.45%   -0.17%     
==========================================
  Files         307      307              
  Lines       32431    32495      +64     
==========================================
- Hits        23552    23545       -7     
- Misses       8879     8950      +71     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WouterSteman
Wouter Steman (WouterSteman) marked this pull request as ready for review October 21, 2026 14:05
@WouterSteman
Wouter Steman (WouterSteman) requested a review from a team as a code owner October 21, 2026 14:05
Copilot AI balanced review requested due to automatic review settings October 21, 2026 14:05
@WouterSteman

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree company="Microsoft"

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Malformed replies can still produce incorrect positions or bypass retries, and blocking controller reads can prevent timeout enforcement.

3 open issues
What changed in this PR

Hardens the Galil DMC-41x3 driver’s connection handling and motion polling.

Changes:

  • Adds reply parsing with retries for motion flags and positions.
  • Tries fallback connection address formats.
  • Centralizes axis-specific motion waiting with a configurable timeout.
File Description
src/​qcodes/​instrument_drivers/​Galil/​dmc_41x3.py Adds parsing helpers, connection fallbacks, and shared motion waits.
docs/​changes/​newsfragments/​8647.improved_driver Documents retries, timeouts, connection fallbacks, and interrupt handling.

Review effort: Balanced

Comment thread src/qcodes/instrument_drivers/Galil/dmc_41x3.py Outdated
Comment thread src/qcodes/instrument_drivers/Galil/dmc_41x3.py Outdated
Comment thread src/qcodes/instrument_drivers/Galil/dmc_41x3.py Outdated

Copilot AI commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Fetch main branch

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants