Fix TestContentMapperOpenFileExcludedByConfigChange race - #64137
Merged
Jake Bailey (jakebailey) merged 1 commit intoSep 2, 2026
Merged
Conversation
Jake Bailey (jakebailey)
requested review from
Andrew Branch (andrewbranch)
and
a balanced review from Copilot
September 2, 2026 17:23
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Copilot started reviewing on behalf of
Jake Bailey (jakebailey)
September 2, 2026 17:24
View session
Andrew Branch (andrewbranch)
approved these changes
Sep 2, 2026
Jake Bailey (jakebailey)
enabled auto-merge
September 2, 2026 17:25
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test-only change matches the established fix for the same deferred-cleanup race.
Pull request overview
Makes TestContentMapperOpenFileExcludedByConfigChange deterministic by accounting for deferred inferred-project cleanup.
Changes:
- Waits for the configuration update to finish.
- Opens another file to trigger deferred cleanup before assertions.
File summaries
| File | Description |
|---|---|
tsc/internal/project/contentmapper_test.go |
Synchronizes project updates and cleanup in the test. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same thing as #64081 fixed, but in another test: https://github.com/microsoft/TypeScript/actions/runs/33623965145/job/100227239918